Skip to content

Simplify LobbyPlayer.equals() return logic #9591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
benhunter wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Simplify LobbyPlayer.equals() return logic #9591

benhunter wants to merge 3 commits into from
+2 −7

Conversation

@benhunter
Copy link
Contributor

@benhunter benhunter commented Jan 22, 2026

No description provided.

@Hanmac Hanmac requested a review from tool4ever January 22, 2026 08:14
@Hanmac Hanmac requested a review from tehdiplomat January 23, 2026 10:35
@Jetz72
Copy link
Contributor

Jetz72 commented Jan 23, 2026

Could simplify it even further with an Objects.equals.

@Hanmac
Copy link
Contributor

Hanmac commented Jan 23, 2026

Also, Objects.hash for the hashCode function.
(but i can do that later)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hanmac Hanmac Hanmac approved these changes

@tool4ever tool4ever Awaiting requested review from tool4ever

@tehdiplomat tehdiplomat Awaiting requested review from tehdiplomat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benhunter @Jetz72 @Hanmac