Fix AI for Forge of Heroes and similar counter-boon pump wrappers#10620
Open
Madwand99 wants to merge 2 commits intoCard-Forge:masterfrom
Open
Fix AI for Forge of Heroes and similar counter-boon pump wrappers#10620Madwand99 wants to merge 2 commits intoCard-Forge:masterfrom
Madwand99 wants to merge 2 commits intoCard-Forge:masterfrom
Conversation
tool4ever
reviewed
May 7, 2026
tool4ever
reviewed
May 7, 2026
tool4ever
reviewed
May 7, 2026
tool4ever
reviewed
May 8, 2026
| Types:Land | ||
| A:AB$ Mana | Cost$ T | Produced$ C | SpellDescription$ Add {C}. | ||
| A:AB$ Pump | Cost$ T | ValidTgts$ Card.IsCommander+ThisTurnEntered | TgtPrompt$ Select target commander that entered this turn | SubAbility$ DBPutCounter | StackDescription$ SpellDescription | SpellDescription$ Choose target commander that entered this turn. Put a +1/+1 counter on it if it's a creature and a loyalty counter on it if it's a planeswalker. | ||
| A:AB$ Pump | Cost$ T | ValidTgts$ Card.IsCommander+ThisTurnEntered | AILogic$ AnyPhase | AITgts$ Card.IsCommander+ThisTurnEntered+YourTeamCtrl | TgtPrompt$ Select target commander that entered this turn | SubAbility$ DBPutCounter | StackDescription$ SpellDescription | SpellDescription$ Choose target commander that entered this turn. Put a +1/+1 counter on it if it's a creature and a loyalty counter on it if it's a planeswalker. |
Contributor
There was a problem hiding this comment.
you don't need to repeat the parts of the normal target legality in AITgts$ again
I also meant if you can't just script it without PumpEffect at all (otherwise this will be ok too)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an AI targeting issue where Forge of Heroes could target an opponent’s commander instead of the AI’s own commander.
Added regression tests confirming that Forge of Heroes targets the AI’s own commander even when the opponent’s commander is also legal and stronger.
Tested with:
mvn -pl forge-gui-desktop -am -Dtest=forge.ai.ability.PumpAiTest -Dsurefire.failIfNoSpecifiedTests=false test
Fixes #9641