Fixed duplicates in commander generated decks#10000
Open
kojotak wants to merge 1 commit intoCard-Forge:masterfrom
Open
Fixed duplicates in commander generated decks#10000kojotak wants to merge 1 commit intoCard-Forge:masterfrom
kojotak wants to merge 1 commit intoCard-Forge:masterfrom
Conversation
kojotak
changed the title
Agetian
approved these changes
Mar 16, 2026
Contributor
|
@Agetian might need to look into why it got the wrong CN? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #9985
I don't know why, but
Pir, Imaginative Rascalloaded fromCardRelationMatrixGenerator.cardPoolshas collectorNumnerN.A.. That is not the case if loading fromStaticData.instance().getCommonCards()(this returns 11 and 1050). TheN.A.collectorNumber results inequalsmethod returning false in an attempt to remove this card from the deck, causingPir, Imaginative Rascalbeeing duplicated (in main deck and as a commander partner).With this change, the card generated deck for
Toothy, Imaginary Friendcan be loaded: