Optimize editor export speed with Rust #1424
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: richiemcilroy1 <richiemcilroy1@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This commit refactors the H264 encoder selection logic to be more organized and platform-agnostic. It introduces a new function `get_hw_encoder_names` to retrieve available hardware encoders based on the target operating system. The encoder configuration is also updated to use a match statement for better readability and maintainability. Co-authored-by: richiemcilroy1 <richiemcilroy1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement comprehensive optimizations for lightning-fast video export by leveraging hardware encoders, GPU pipelining, and frame prefetching.
This PR introduces several advanced optimizations to drastically reduce video export times. It prioritizes hardware video encoders (VideoToolbox on macOS, NVENC on Windows/Linux) with optimized settings, falling back to a highly tuned, multi-threaded
libx264software encoder. A 3-frame deep GPU rendering pipeline is implemented to overlap rendering and readback, coupled with async, double-buffered GPU readbacks. Additionally, decoders now prefetch upcoming frames, and internal pipeline buffers have been increased to handle higher throughput.