-
-
Notifications
You must be signed in to change notification settings - Fork 85
feat: track daily demo app onboarding metric #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,4 @@ | ||||||
| ALTER TABLE public.global_stats | ||||||
| ADD COLUMN demo_apps_created integer NOT NULL DEFAULT 0; | ||||||
|
|
||||||
| COMMENT ON COLUMN public.global_stats.demo_apps_created IS 'Number of demo apps created in the last 24 hours'; | ||||||
|
||||||
| COMMENT ON COLUMN public.global_stats.demo_apps_created IS 'Number of demo apps created in the last 24 hours'; | |
| COMMENT ON COLUMN public.global_stats.demo_apps_created IS 'Number of demo apps created during the current UTC day (00:00–24:00 UTC)'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This query counts demo apps using a UTC calendar-day window (
created_at>= todayStartIso and < tomorrowStartIso). The migration/comment/PR text describe "last 24 hours" and other metrics here use the rollinglast24hwindow, so the semantics are inconsistent (and can be a partial-day count depending on when the cron runs). Either switch togte('created_at', last24h)or rename/document this as "created today (UTC)" end-to-end.