Implement cross-reactor Jacobian terms for preconditioners#2113
Open
speth wants to merge 9 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2113 +/- ##
==========================================
+ Coverage 77.69% 77.75% +0.06%
==========================================
Files 452 452
Lines 53203 53467 +264
Branches 8864 8920 +56
==========================================
+ Hits 41335 41574 +239
- Misses 8867 8879 +12
- Partials 3001 3014 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
Co-authored-by: OpenAI Codex <codex@openai.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Anthony Walker <walkanth@oregonstate.edu> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
59700e7 to
5c555b6
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ischoegl
reviewed
May 16, 2026
Member
There was a problem hiding this comment.
I believe that there should be one sample file per application. I.e.., my preference would be to rename the pre-existing file to preconditioned_ignition.py and add new content as preconditioned_network.py or similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
IdealGasMoleReactorandIdealGasConstPressureMoleReactor.ExtensibleReactorinterface for setting Jacobian elements (get_jacobian_elements)ReactorNet.jacobianandReactorNet.finite_difference_jacobianaccessors for full-network Jacobians (in contrast to just the reactor-local parts available on eachReactorIf applicable, fill in the issue number this pull request is fixing
AI Statement (required)
Significant portions of code or documentation were generated with AI, including logic and implementation decisions. All generated code and documentation were reviewed and understood by the contributor. Implemented using Claude Code (Sonnet 4.6) and OpenAI Codex (ChatGPT-5.5).
Checklist
scons build&scons test) and unit tests address code coverage