feat(a11y): accessibility audit for settings pages (#612)#783
Open
AnnieIj wants to merge 1 commit into
Open
Conversation
- Add <main id="main-content"> landmark to settings index page - Add explicit htmlFor/id label association on delete modal textarea - Add autoFocus to first focusable element in delete confirmation dialog - Mark decorative SVG icons aria-hidden across settings pages - Ensure aria-current="page" on active nav tab (notifications page) - Ensure remove buttons have aria-label in ReminderSettings - Add jest-axe devDependency for axe-based assertions - Add settings-a11y.test.tsx: 15 axe + structural tests covering settings, privacy, notifications, and security pages Closes Calebux#612
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #612 — P1 accessibility audit for
client/app/settings/.Changes
<main id="main-content">landmarkhtmlFor/idon delete modal textarea;autoFocuson Cancel button so focus enters dialog on openaria-hidden;aria-current="page"on active nav tabaria-labelon remove-day buttons;Xicon markedaria-hiddenAcceptance Criteria
Testing
cd client && npm test -- --run app/settings/__tests__/settings-a11y.test.tsx15/15 pass
Security
No auth, data handling, or infrastructure changes.