jnigen: reference README in JDK guidance message#4
Open
Cairo09 wants to merge 2 commits into
Open
Conversation
Cairo09
force-pushed
the
codex/evaluate-support-for-variadic-parameters
branch
from
9cc5eee to
c11dd76
Compare
Cairo09
force-pushed
the
codex/evaluate-support-for-variadic-parameters
branch
from
c11dd76 to
212222d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
getActionableSummaryParseMessageinpkgs/jnigen/lib/src/summary/summary.dartto sayUse a supported JDK version (11 to 17) (see JNIgen README), and updated the unit test expectation inpkgs/jnigen/test/summary_error_message_test.dartto match.Testing
getActionableSummaryParseMessageunit test but could not rundart testordart formatin this environment because thedart/fluttertoolchain is unavailable; the changes were committed successfully.