Skip to content

[WIP] Fix parseType logic in type parser#13

Closed
Copilot wants to merge 1 commit into
mainfrom
copilot/fix-parse-type-logic
Closed

[WIP] Fix parseType logic in type parser#13
Copilot wants to merge 1 commit into
mainfrom
copilot/fix-parse-type-logic

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 20, 2026

  • Investigate the mentor's PR review feedback and understand required changes
  • Add ClosureType to referred_type.dart and visitClosureType to visitor.dart
  • Update token_list.dart (add : to splittables)
  • Rewrite parse_type.dart:
    • No separate parseType/_parseTypeExpression wrapper
    • No _parseTypeExpressionUntilArrow hack
    • No _parseClosureModifiers in _maybeParseSuffixTypeExpression
    • Handle async/throws inside _tupleParselet
    • Add _closureSuffixParselet for text: ->
    • Add _attributeParselet for attribute kind
  • Update transform/_core/utils.dart: add ClosureType handling to maybeWrapValue and maybeUnwrapValue
  • Update transform_referred_type.dart: handle ClosureType
  • Update transform_function.dart: remove switch statements, use maybeWrapValue/maybeUnwrapValue directly
  • Update transform_initializer.dart: pass globalNamer/state to generateInvocationParams
  • Update transform_variable.dart: pass globalNamer/state to maybeUnwrapValue
  • Create closures_input.swift with comprehensive test cases
  • Generate closures_output.swift (run integration tests with --regen)
  • Create unit tests: parse_type_test.dart, closure_transform_test.dart, parse_function_info_test.dart
  • Update CHANGELOG.md
  • Run tests to verify all changes

⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

Copilot AI requested a review from Cairo09 March 20, 2026 17:44
Copilot stopped work on behalf of Cairo09 due to an error March 20, 2026 17:44
@Cairo09 Cairo09 closed this Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants