Fix toggle-favourite HTTPException handling and add DB helper + tests. #issue 1179#1
Open
Cairo09 wants to merge 2 commits into
Open
Fix toggle-favourite HTTPException handling and add DB helper + tests. #issue 1179#1Cairo09 wants to merge 2 commits into
Cairo09 wants to merge 2 commits into
Conversation
Remove docstring for db_get_image_favourite_status function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
toggle_favourite()route from converting intendedHTTPExceptionresponses (e.g. 404) into generic 500 errors.isFavouritevalue.Description
backend/app/routes/images.pyto explicitly re-raiseHTTPExceptionand handle unexpected errors with a genericexcept Exceptionreturning 500.toggle_favourite()with a call to the new helperdb_get_image_favourite_status(image_id)and used that value in the response.db_get_image_favourite_status()and switcheddb_toggle_image_favourite_status()to use the shared_connect()helper inbackend/app/database/images.py.backend/tests/test_images.pythat mock DB calls to cover a successful toggle and the unknown-image 404 case.Testing
python -m py_compile backend/app/routes/images.py backend/app/database/images.py backend/tests/test_images.pywhich succeeded.pytest backend/tests/test_images.pyin this environment and it failed during test bootstrap due to an external system library import error (cv2->libGL.so.1missing), preventing full test execution.Codex Task