Skip to content

Locales: Fix zh-CN full-width percent sign syntax#291

Closed
somethingwithproof wants to merge 5 commits intoCacti:developfrom
somethingwithproof:fix/zh-cn-syntax
Closed

Locales: Fix zh-CN full-width percent sign syntax#291
somethingwithproof wants to merge 5 commits intoCacti:developfrom
somethingwithproof:fix/zh-cn-syntax

Conversation

@somethingwithproof
Copy link
Contributor

This PR fixes a critical syntax issue in the Simplified Chinese (zh-CN) localization where full-width Unicode percent signs () were used instead of standard ASCII percent signs (%). Includes automated security hardening for hostlist validation and command execution.

Copy link
Member

@TheWitness TheWitness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this .omc/sessions direcotory. I don't believe that belongs in the repo.

Copy link
Member

@TheWitness TheWitness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of this .omc directory. Thanks!

@somethingwithproof
Copy link
Contributor Author

Removed .omc directory. Slipped past global gitignore during initial commit.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof added a commit to somethingwithproof/plugin_syslog that referenced this pull request Mar 18, 2026
- Sync syntax and variable placeholder fixes for all locales from Cacti#296
- Sync zh-CN full-width percent sign fixes from Cacti#291
- Standardized all .po files with 'msgcat --no-wrap' as requested by maintainers
- Verified all language files with 'msgfmt --check' (zero fatal errors)
@somethingwithproof
Copy link
Contributor Author

Superseded by #297

somethingwithproof added a commit to somethingwithproof/plugin_syslog that referenced this pull request Mar 19, 2026
- Sync syntax and variable placeholder fixes for all locales from Cacti#296
- Sync zh-CN full-width percent sign fixes from Cacti#291
- Standardized all .po files with 'msgcat --no-wrap' as requested by maintainers
- Verified all language files with 'msgfmt --check' (zero fatal errors)
TheWitness pushed a commit that referenced this pull request Mar 19, 2026
- Sync syntax and variable placeholder fixes for all locales from #296
- Sync zh-CN full-width percent sign fixes from #291
- Standardized all .po files with 'msgcat --no-wrap' as requested by maintainers
- Verified all language files with 'msgfmt --check' (zero fatal errors)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants