Skip to content

fix(sql): migrate interpolated queries to prepared statements #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
somethingwithproof wants to merge 1 commit into from
Closed

fix(sql): migrate interpolated queries to prepared statements #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ function audit_poller_bottom() {
$retention = read_config_option('audit_retention');

if ($retention > 0) {
db_execute('DELETE FROM audit_log WHERE event_time < FROM_UNIXTIME(' . (time() - ($retention * 86400)) . ')');
db_execute_prepared('DELETE FROM audit_log WHERE event_time < FROM_UNIXTIME(?)', array(time() - ($retention * 86400)));
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says it migrates the remaining interpolated SQL queries to prepared statements, but this file still has variable-interpolated UPDATEs to plugin_config (e.g., SET version='$current' and string-concatenated name/author/webpage updates in audit_check_upgrade()). Either convert those to prepared statements as well, or adjust the PR description/scope so it matches the actual change set.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

@somethingwithproof somethingwithproof Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Only the one query with variable interpolation was converted. The others are static SQL.

$rows = db_affected_rows();
cacti_log('NOTE: Purged ' . $rows . ' Audit Log Records from Cacti', false, 'POLLER');
}
Expand Down
Loading