Skip to content

Resolves issue #1673, Handling read-after-writes in the registry user controller #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afoote-mitre wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Resolves issue #1673, Handling read-after-writes in the registry user controller #1823

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfbdc2b
Properly handling read-after-writes in registry user controller
afoote-mitre May 22, 2026
d67ce80
Fixing linting issues from last commit
afoote-mitre May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/controller/registry-user.controller/registry-user.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,10 @@ async function updateUser (req, res, next) {
}
}

// UUID of the user will not change, lets get it before we write to avoid read after write issues.
// Move lookups of immutable properties BEFORE the transaction mutation writes to completely bypass read-after-write anomalies
const requestingUserUUID = await userRepo.getUserUUID(req.ctx.user, req.ctx.org, { session })
updatedUserUUID = await userRepo.getUserUUID(req.ctx.user, org.UUID)
updatedUserUUID = await userRepo.getUserUUID(req.ctx.user, org.UUID, { session })

updatedUser = await userRepo.updateUserFull(userToEdit.UUID, body, { session }, true, requestingUserUUID)
await session.commitTransaction()
} catch (error) {
Expand Down Expand Up @@ -456,7 +457,8 @@ async function deleteUser (req, res, next) {
}

async function grantRole (req, res, next) {
const session = await mongoose.startSession()
// Explicitly configuring causalConsistency flag for clear DocumentDB context documentation
const session = await mongoose.startSession({ causalConsistency: false })
try {
const orgShortName = req.ctx.params.shortname
const username = req.ctx.params.username
Expand Down Expand Up @@ -519,7 +521,8 @@ async function grantRole (req, res, next) {
}

async function revokeRole (req, res, next) {
const session = await mongoose.startSession()
// Explicitly configuring causalConsistency flag for clear DocumentDB context documentation
const session = await mongoose.startSession({ causalConsistency: false })
try {
const orgShortName = req.ctx.params.shortname
const username = req.ctx.params.username
Expand Down
Loading