Ref Update 2026#193
Draft
roccoagain wants to merge 14 commits into
Draft
Conversation
|
Doxygen warnings output: (if empty, there are no warnings). Please correct any warnings before merging. |
ericv555
requested changes
May 28, 2026
Collaborator
ericv555
left a comment
ericv555
left a comment
There was a problem hiding this comment.
Looks solid 1 or 2 big bugs most other comments are small optimizations.
| read_mcm(); | ||
| } | ||
|
|
||
| void RefSystem::write(uint8_t* packet, uint8_t length) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| void RefSystem::write(uint8_t* packet, uint16_t length) { |
length can now be up to 309 which exceeds uint8_t max size.
Collaborator
Author
There was a problem hiding this comment.
Holy good catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to align with RoboMaster’s 2026 spec.
RMU 2026 Communication Protocol