Test: Nominee endpoint #127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactored how the election officers are looked up * changed the Nominee put back to a patch * made election tests work with the new testing setup
p-north
reviewed
Jan 17, 2026
| query = query.where(BlogPosts.title == title) | ||
|
|
||
| # should return the one entry with an unique title | ||
| post = await db_session.scalar(query) |
Contributor
There was a problem hiding this comment.
nit pick: might wanna check if post is none
p-north
reviewed
Jan 17, 2026
Comment on lines
+54
to
+55
| query = query.where(BlogPosts.post_tags in tags).where(BlogPosts.last_edited).order_by(BlogPosts.last_edited.desc()) | ||
| # .all() should return a list of all the posts |
Contributor
There was a problem hiding this comment.
slight syntax issue for sqlalchemy. BlogPosts.post_tags in tags is invalid syntax
Correction: query = query.where(BlogPosts.post_tags.contains(tags)).order_by(BlogPosts.last_edited.desc())
p-north
reviewed
Jan 17, 2026
| detail="candidate is already registered for that position", | ||
| ) | ||
|
|
||
| registration.update_from_params(body) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #126