Skip to content

Update: Election Part 3 #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jbriones1 wants to merge 48 commits into
base: main
Choose a base branch
from
Open

Update: Election Part 3 #120

jbriones1 wants to merge 48 commits into from

Conversation

@jbriones1
Copy link
Contributor

@jbriones1 jbriones1 commented Sep 27, 2025 •
edited
Loading

depends on #125

Added the following endpoints:

  • GET /registration: get all registrations
  • POST /nominee: create a nominees
  • GET /nominee: get all nominees
  • DELETE /nominee: delete a nominee
  • Fixed elections tests

@jbriones1 jbriones1 marked this pull request as ready for review September 28, 2025 21:53
@jbriones1 jbriones1 requested a review from p-north September 28, 2025 21:53
@jbriones1 jbriones1 force-pushed the feat_elections-api-part3 branch from 82dccf7 to 13f51bb Compare December 15, 2025 08:43
@jbriones1 jbriones1 marked this pull request as draft December 17, 2025 04:22
@jbriones1
fix(ci): split test and dev dependencies again, update action script
01cb9f4
@jbriones1
fix(ci): removed requirements.txt requirement
8fe4e74
@jbriones1
fix(uv): update uv.lock to current state
5ab91f4
@jbriones1
refactor(permissions): rewrote permissions to integrate admin types
f571eb3
@jbriones1
fix: type errors in officers crud
74bc701
@jbriones1
refactor(permissions): restructured most endpoints to use Depends
4873317
@jbriones1
fix(tests): whole test suite can now be run
6c880e1
@jbriones1
fix: missing awaits on permission check calls
268fd97
@jbriones1
fix(officers): tests now all work
69469e1
@jbriones1
fix: move conftest.py to only work on integrations tests
6e39610
@jbriones1
wip: add GET all registrations
3eeaebc
@jbriones1
wip(nominee): add create endpoint
150f08c
@jbriones1
wip: add GET all nominees
32a3ee0
@jbriones1
wip: add DELETE nominee_info
8492ff0
@jbriones1
fix(Elections): duplicate operation id in nominees URLs
3fa406a
@jbriones1
fix: patch to put
95ad68e
@jbriones1
fix: election tests now work
a751e67 
* refactored how the election officers are looked up
* changed the Nominee put back to a patch
* made election tests work with the new testing setup
@jbriones1
fix(tests): add missing param types
56f3585
@jbriones1
refactor: split election tests into multiple functions
f8824f7
@jbriones1 jbriones1 force-pushed the feat_elections-api-part3 branch from 13f51bb to 0f2a339 Compare December 21, 2025 19:40
@jbriones1
fix(registrations): change return type to list
af31465
@jbriones1
fix(registration): fix list being sent as a JSON response
a1dc6b3
@jbriones1
fix(registratio): removed enum check
812185e
@jbriones1
fix(registration): changed search to a single registration
efa5042
@jbriones1
refactor(officers): response for current officers changed to list
512bc66
@jbriones1
fix(officers): tests that expect a dict response for current officers
1d7a4c9
@jbriones1
fix(Officers): merged the public and private models
908e6ad
@jbriones1
chore(OfficerInfoDB): remove unused methods
316c1b6
@jbriones1
fix(test): user client is now module scoped
2e4ce2c
@jbriones1
fix(officers): model fields use OfficerPositionEnum
6b4fc15
@jbriones1
refactor: made a computed field
bd9e3ad
@jbriones1
fix(officers): term_id added to Officer response, id is now an int
6f7d55a
@jbriones1
refactor: rename OfficerUpdate to OfficerInfoUpdate
6293336
@jbriones1
refactor: change csss_email to a computed field
91941f9
@jbriones1
chore(officers): delete old types
846446c
@jbriones1
fix: remove csss_email
49a3c9b
@jbriones1
fix: check that end_date is null for current officers
68a5eba
@jbriones1
fix: tests failed after the check for current admin changed
2b44419
@jbriones1 jbriones1 mentioned this pull request Dec 30, 2025
Open
@jbriones1 jbriones1 marked this pull request as ready for review January 3, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-north p-north Awaiting requested review from p-north

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbriones1