Skip to content

Update raven-hydro to v5.0 (RavenHydroFramework v4.1.0) #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zeitsperre wants to merge 3 commits into
base: unpin-deps
Choose a base branch
from
Open

Update raven-hydro to v5.0 (RavenHydroFramework v4.1.0) #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c561e3
update raven-hydro to v5.0 (RavenHydroFramework v4.1.0)
Zeitsperre Dec 22, 2025
ead00e7
update CHANGELOG.rst
Zeitsperre Dec 22, 2025
77b595f
update SACSMA expected test values
Zeitsperre Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ Changelog

Contributors: David Huard (:user:`huard`), Trevor James Smith (:user:`Zeitsperre`).

New features
^^^^^^^^^^^^
* Updated `raven-hydro` to v0.5.0 (`RavenHydroFramework` v4.1.0). (PR #560)

Fixes
^^^^^
* Fix `Reservoir` command parser failing when optional fields were missing. (PR #544)
Expand Down
2 changes: 1 addition & 1 deletion environment-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ channels:
- conda-forge
dependencies:
- python >=3.10,<3.14
- raven-hydro >=0.4.0,<1.0
- raven-hydro >=0.5.0,<1.0
# - libgcc # for mixing raven-hydro from PyPI with conda environments
- affine >=2.4.0
- cftime >=1.4.1
Expand Down
2 changes: 1 addition & 1 deletion environment-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ channels:
- conda-forge
dependencies:
- python >=3.12,<3.13
- raven-hydro >=0.4.0,<1.0
- raven-hydro >=0.5.0,<1.0
- autodoc-pydantic >=2.1.0
- birdy
- cairosvg >=2.6.0
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ gis = [
"shapely >=2.0"
]
raven-hydro = [
"raven-hydro >=0.4.0,<1.0"
"raven-hydro >=0.5.0,<1.0"
]
all = [
"ravenpy[dev]",
Expand Down
5 changes: 3 additions & 2 deletions tests/test_emulators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
# "CanadianShield": 0.3968, <- This is the value for CanadianShield with RavenHydroFramework v3.7
"CanadianShield": 0.4001, # <- This is the new value for CanadianShield with RavenHydroFramework v3.8 and v3.8.1
"HYPR": 0.685188,
"SACSMA": -0.0382907,
# "SACSMA": -0.0383, # <- This is the original value for SACSMA with RavenHydroFramework v3.8.1 and v4.0.0
"SACSMA": -0.2666,
# "Blended": -0.913785, <- This is the original value for Blended with RavenHydroFramework v3.8.1
"Blended": -1.1507, # <- This is the new value for Blended with RavenHydroFramework v4.0.1
}
Expand All @@ -42,7 +43,7 @@ def test_run(numeric_config, tmp_path):
out = e.run()
d = out.diagnostics

np.testing.assert_almost_equal(d["DIAG_NASH_SUTCLIFFE"], NSE[name], 4)
np.testing.assert_almost_equal(d["DIAG_NASH_SUTCLIFFE"], [NSE[name]], 4)

if name == "CanadianShield":
pytest.skip("Missing solution due to SuppressOutput.")
Expand Down