Skip to content

Conversation

@huard
Copy link
Collaborator

@huard huard commented Nov 29, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Unpin pymbolic
  • Resolve issue with pymbolic > 2022.2
  • Tweaks to silence pydantic DeprecationWarning

Does this PR introduce a breaking change?

Python3.9 support has been dropped.

Other information:

@github-actions github-actions bot added the docs label Nov 29, 2024
@huard huard requested a review from Zeitsperre November 29, 2024 18:50
@Zeitsperre
Copy link
Member

@huard If you want to implement a drop of Python3.9 in order to address the problem, go for it. We've been progressively dropping that version in a few places already.

@github-actions github-actions bot added the CI label Nov 29, 2024
@coveralls
Copy link

coveralls commented Nov 29, 2024

Coverage Status

coverage: 81.279% (-0.07%) from 81.352%
when pulling ede6f94 on fix-418
into 57b7df4 on master.

Copy link
Member

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

A few final changes:

  • In .pre-commit.config.yml, change the pyupgrade hook to py310-plus
  • In pyproject.toml, change the ruff and isort configs to use "310" instead of "39", and drop py39 from black.

The remaining formatting should be automated by pre-commit.

@Zeitsperre Zeitsperre merged commit 1da26b4 into master Dec 2, 2024
15 checks passed
@Zeitsperre Zeitsperre deleted the fix-418 branch December 2, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Params is_symbolic failing on linux

4 participants