Skip to content

feat: add an explicit error for json in the filter for get request#115

Open
cauriol wants to merge 2 commits into
mainfrom
filter_json
Open

feat: add an explicit error for json in the filter for get request#115
cauriol wants to merge 2 commits into
mainfrom
filter_json

Conversation

@cauriol
Copy link
Copy Markdown
Contributor

@cauriol cauriol commented May 29, 2026

Add explicit validation for GET filter parameters containing JSON/dictionary objects and return a clear 400 error telling users to use POST with a JSON body for that kind of filter.

@cauriol cauriol self-assigned this May 29, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

Test Results

  4 files  ±0    4 suites  ±0   1m 36s ⏱️ -6s
114 tests +1  114 ✅ +1  0 💤 ±0  0 ❌ ±0 
456 runs  +4  456 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit d73a82a. ± Comparison against base commit a06e930.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

badge

Code Coverage

Details
Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------
eodag/__init__.py                            0       0  100.00%
eodag/app.py                                73      15  79.45%   122, 136-143, 154-156, 212-224, 228
eodag/client.py                             25       0  100.00%
eodag/config.py                             19       0  100.00%
eodag/constants.py                           5       0  100.00%
eodag/core.py                              318      27  91.51%   136-137, 147, 293-294, 384, 518-519, 538, 581, 667, 683-687, 701-705, 707-711, 716, 729, 739-741, 744-745, 755, 758, 774
eodag/cql_evaluate.py                       48      18  62.50%   48, 53, 58, 75, 78, 81, 86-99, 105
eodag/dag.py                                57       0  100.00%
eodag/errors.py                             94       7  92.55%   145, 162-165, 181, 205
eodag/logs.py                               62       9  85.48%   40-49, 105
eodag/middlewares.py                        32       2  93.75%   20, 24
eodag/telemetry.py                          44       0  100.00%
eodag/utils.py                              41      10  75.61%   44, 69, 72-73, 86, 90-98, 134
eodag/eodag_types/__init__.py                0       0  100.00%
eodag/eodag_types/queryables.py             42       8  80.95%   46, 50-51, 61, 77-81
eodag/eodag_types/search.py                 25      25  0.00%    20-69
eodag/extensions/collection_order.py        73       1  98.63%   106
eodag/extensions/data_download.py          121      42  65.29%   61-73, 94, 112-113, 120, 135-142, 147-148, 155-187, 195-198
eodag/extensions/filter.py                 106      10  90.57%   185-186, 228, 286-287, 307, 315, 321, 339-341
eodag/extensions/offset_pagination.py       12       0  100.00%
eodag/models/__init__.py                     0       0  100.00%
eodag/models/item.py                        82       6  92.68%   49-52, 54, 67
eodag/models/links.py                      148      13  91.22%   39, 93-95, 201, 219, 251, 299, 348-359
eodag/models/stac_metadata.py                5       0  100.00%
TOTAL                                     1432     193  86.52%

Diff against main

Filename         Stmts    Miss  Cover
-------------  -------  ------  -------
eodag/core.py       +2       0  +0.05%
TOTAL               +2       0  +0.02%

Results for commit: d73a82a

Minimum allowed coverage is 70%

♻️ This comment has been updated with latest results

@cauriol cauriol marked this pull request as ready for review May 29, 2026 09:35
@cauriol cauriol requested a review from jlahovnik May 29, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant