Skip to content

[add] ESP32 twai library #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IamMichaelthankyou merged 42 commits into from
Feb 22, 2025
Merged

[add] ESP32 twai library #40

IamMichaelthankyou merged 42 commits into from
Feb 22, 2025

Conversation

@Natsu-B
Copy link
Member

@Natsu-B Natsu-B commented Feb 7, 2025

変更概要

ESP32のtwaiを用いたCANのライブラリの実装を行った

後方互換性

  • 既存コードとの後方互換性を保っている

動作確認

  • 実際にセンサを接続して動作確認を行った

種別

  • 新規センサのライブラリ

  • 既存センサのライブラリ

    • 新機能の追加
    • バグ修正
    • その他

変更点の詳細

twai.hの薄いラッパーとなるライブラリを作成しました。以前使っていたライブラリと互換性があるモードを搭載しているため、昔のコードもそのまま使えます。 より詳しい説明は、READMEを参照していただけるとありがたいです。

⚠️ 最終的な動作確認を行っている途中です。
また、ファイル名、配置等でライブラリとして合わせるために変更するべき点があれば教えてください。
あと、このままではCAN.hという名前がついたファイルが2つ存在してしまうのでどのような対処をするか悩んでいます。

Natsu-B and others added 30 commits January 13, 2025 00:03
@Natsu-B
[add]esp32 s3 support (WIP)
baca114
@Natsu-B
[add] CAN library ver 0.1
2e5fbcc
@Natsu-B
Merge branch 'CREATE-ROCKET:main' into main
e1f7906
@Natsu-B
[fix] CAN_ESP32 readme typo
0f99ecf
@Natsu-B
[refactor] skip define pr_debug when pr_debug already defined
4246ee7
@Natsu-B
[add] can watch dog timer (unverified)
9921211
@Natsu-B
[fix] fix versioning
0522876 
issue #4 #4
@Natsu-B
[fix] add old_mode_block in
d10e775 
new begin function
@Natsu-B
[add] add getStatus (unverified) #2
041e466
@Natsu-B
[add] getStatus readme example
1cefb04
@Natsu-B
[fix] forget semicolon
5de3a7e
@Natsu-B
[add] can_setting_t test readWithDetail #3 #5
5c96f87
@Natsu-B
[fix] acceptance_mask_bit size is 32bit
0fa0564
@Natsu-B
[refactor] change comment type #6
48f47dc
@Natsu-B
[fix] typo
83cf4ad
@Natsu-B
[fix] invalid repeat counter
99a0546
@Natsu-B
[fix] test function
0fd6f86
@Natsu-B
[fix] revert __attribute__(weak) to define
4bcd8d0
@Natsu-B
[add] add max wait time in transit and read
cb566c1
@Natsu-B
[fix] in test function set twai mode TWAI_MODE_NO_ACK
65324f1
@Natsu-B
[fix] re_configure function maybe always failed
a0b07a6
@Natsu-B
[fix] fix error #7 and refactor comment
62d2bec
@Natsu-B
Merge remote-tracking branch 'refs/remotes/origin/main'
932d543
@Natsu-B
[add] support ESP IDF (WIP)
f21e840
@Natsu-B
[fix] invalid default id and delete default constructor in can_setting_t
dd3fa43
@Natsu-B
[refactor] add function example comment
1946ba9
@Natsu-B
[add] suspend resume function and update version
ddb9be0
@Natsu-B
[fix] return value was incorrect by documentation
c6a60d6
@Natsu-B
[fix] release build can't finished
0ba84b9
@Natsu-B
[doc] update document info
aaf9de7
@Natsu-B
Copy link
Member Author

Natsu-B commented Feb 11, 2025

動作のチェック等終了しました

@Natsu-B Natsu-B marked this pull request as ready for review February 11, 2025 09:02
IamMichaelthankyou
IamMichaelthankyou approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@IamMichaelthankyou IamMichaelthankyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいと思います！

@IamMichaelthankyou IamMichaelthankyou merged commit e0b3545 into CREATE-ROCKET:main Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IamMichaelthankyou IamMichaelthankyou IamMichaelthankyou approved these changes

@Watanabe1101 Watanabe1101 Awaiting requested review from Watanabe1101

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Natsu-B @IamMichaelthankyou