Skip to content

Skip METISSE mass bounds check for massless objects#789

Merged
katiebreivik merged 1 commit into
COSMIC-PopSynth:developfrom
d-maclean:massless_abandon
May 29, 2026
Merged

Skip METISSE mass bounds check for massless objects#789
katiebreivik merged 1 commit into
COSMIC-PopSynth:developfrom
d-maclean:massless_abandon

Conversation

@d-maclean
Copy link
Copy Markdown
Contributor

Currently, Evolve.evolve will throw an exception if you pass an initial binary table with mass_1/mass_2 = 0 , because we have no zero-mass tracks. I added some logic to skip this if the mass provided is exactly zero.

@github-actions github-actions Bot added the needs-cmc-review PR touches cosmic core settings and needs CMC review label May 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚨 CMC review requested

This pull request modifies one or more of:

  • src/cosmic/evolve.py
  • src/cosmic/data/cosmic-settings.json (only flagged when category: "bse" key-count changes)

Trigger: evolve file changed, probably needs CMC review

A CMC developer should review this PR to ensure corresponding changes are propagated upstream as needed.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.31%. Comparing base (8772c07) to head (a3d052b).
⚠️ Report is 162 commits behind head on develop.

Files with missing lines Patch % Lines
src/cosmic/evolve.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #789       +/-   ##
============================================
- Coverage    86.91%   76.31%   -10.60%     
============================================
  Files           40       58       +18     
  Lines        25542    28096     +2554     
  Branches         0      919      +919     
============================================
- Hits         22198    21440      -758     
- Misses        3344     6352     +3008     
- Partials         0      304      +304     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@katiebreivik katiebreivik self-requested a review May 29, 2026 15:11
Copy link
Copy Markdown
Collaborator

@katiebreivik katiebreivik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@katiebreivik katiebreivik merged commit e1c4b60 into COSMIC-PopSynth:develop May 29, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cmc-review PR touches cosmic core settings and needs CMC review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants