Add new column to kick_info, remove bkick, create what's new page dynamically#786
Merged
Conversation
TomWagg
added
docs
github-actions
Bot
added
the
needs-cmc-review
Contributor
|
🚨 CMC review requested This pull request modifies one or more of:
Trigger: evolve file changed, probably needs CMC review A CMC developer should review this PR to ensure corresponding changes are propagated upstream as needed. |
Collaborator
Author
|
@claireshiye will care about this PR :) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #786 +/- ##
============================================
- Coverage 86.91% 76.32% -10.59%
============================================
Files 40 58 +18
Lines 25542 28092 +2550
Branches 0 919 +919
============================================
- Hits 22198 21440 -758
- Misses 3344 6348 +3004
- Partials 0 304 +304 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
katiebreivik
pushed a commit
to katiebreivik/COSMIC
that referenced
this pull request
May 29, 2026
… dynamically (COSMIC-PopSynth#786) * remove bkick from existence * erase bonus kick_info_out array * add tphys to kick_info * update docs for kick_info * get kick info outputted into evolve * update version * clean up changelog and generate 'whats new' page * fill in extra columns if people just supply sse as stellar engine * actually use the z accuracy limit * fix evolv2 call in the benchmark file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
bkickandkick_info_out, so that CMC can just usekick_infodirectly now that we've added thetphyscolumn.Separately I added a method for dynamically generating a what's new page for the docs from the changelog.
I bumped the version to 4.1