Error check on masses outside of the supplied grid for metisse use#784
Merged
Conversation
github-actions
Bot
added
the
needs-cmc-review
Contributor
|
🚨 CMC review requested This pull request modifies one or more of:
Trigger: evolve file changed, probably needs CMC review A CMC developer should review this PR to ensure corresponding changes are propagated upstream as needed. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #784 +/- ##
============================================
- Coverage 86.91% 76.16% -10.75%
============================================
Files 40 58 +18
Lines 25542 28197 +2655
Branches 0 924 +924
============================================
- Hits 22198 21474 -724
- Misses 3344 6419 +3075
- Partials 0 304 +304 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Looks good! 
|
katiebreivik
added a commit
to katiebreivik/COSMIC
that referenced
this pull request
May 28, 2026
…OSMIC-PopSynth#784) * add recurse submodules to Dockerfile * add minimum and maximum masses for limits checking * add mass limits error * version bump * need to only use m_min if metisse * clean up stellar engine decisions, avoid copied code, store z_accuracy_limit too --------- Co-authored-by: Tom Wagg <tomjwagg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple error check in evolve now to confirm that the masses evolved do not fall outside the limits of the tracks.
flipped the order of the changelog