updated error checking so Evolve.evolve will permit metallicities out…#782
Merged
Conversation
…side the SSE range if METISSE is set as stellar engine
github-actions
Bot
added
the
needs-cmc-review
Contributor
|
🚨 CMC review requested This pull request modifies one or more of:
Trigger: evolve file changed, probably needs CMC review A CMC developer should review this PR to ensure corresponding changes are propagated upstream as needed. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #782 +/- ##
============================================
- Coverage 86.91% 75.96% -10.94%
============================================
Files 40 58 +18
Lines 25542 28279 +2737
Branches 0 990 +990
============================================
- Hits 22198 21482 -716
- Misses 3344 6492 +3148
- Partials 0 305 +305 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed a behavior in Evolve.evolve concerning metallicity bounds checking.
Previously, if you supplied binaries with a
z < 1e-4orz > 3e-2, COSMIC would raise an exception due to the SSE boundaries. This change requires that METISSE not be the stellar engine for this exception to be thrown.