Add smt_periastron_check setting#777
Merged
Merged
Conversation
github-actions
Bot
added
the
needs-cmc-review
Contributor
|
🚨 CMC review requested This pull request modifies one or more of:
Trigger: evolve file changed, probably needs CMC review A CMC developer should review this PR to ensure corresponding changes are propagated upstream as needed. |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (57.89%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #777 +/- ##
===========================================
- Coverage 86.91% 77.24% -9.66%
===========================================
Files 40 50 +10
Lines 25542 27760 +2218
Branches 0 954 +954
===========================================
- Hits 22198 21443 -755
- Misses 3344 6022 +2678
- Partials 0 295 +295 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
smt_periastron_checksetting, which allows the user to toggle whether to check for periastron collision during stable mass transfer. By default, we set this off, which changes the behaviour of previous versions since 3.6.0 (PR #694) which did check for contact at periastron during stable mass transfer. We set this to off as the radial expansion from SSE is likely overestimated, once we connect with COSMIC-METISSE this should likely be set to 1.