Skip to content

Conversation

@bwang-icf
Copy link
Contributor

@bwang-icf bwang-icf commented Dec 12, 2025

JIRA Ticket:
BB2-4307

What Does This PR Do?

Minor version upgrade for microsoft/api-extractor

What Should Reviewers Watch For?

Any portions of code that would be breaking

Validation

Ran npm audit and npm install without issues.

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team security engineer's approval.

Copy link

@JamesDemeryNava JamesDemeryNava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run npm audit on main, I see 3 vulnerabilities, 2 high and 1 moderate:

axios 1.0.0 - 1.11.0
Severity: high
js-yaml <3.14.2 || >=4.0.0 <4.1.1
Severity: moderate
validator <=13.15.20
Severity: high

When I run npm audit in this branch, I see 2 vulnerabilities, 1 high and 1 moderate:

axios 1.0.0 - 1.11.0
Severity: high
js-yaml <3.14.2 || >=4.0.0 <4.1.1
Severity: moderate

So that looks good! @bwang-icf, to see the validator vulnerability be removed for npm audit, I had to run npm install, which also added changes to package-lock.json. Do we typically need to run an npm install when we make changes to package.json in this repository? From looking at some prior PRs in this project, it seems like we do. This PR is still in draft, so maybe i'm getting ahead of myself, my bad if that's the case.

Also, @sb-benohe, just wanted to call out the other high vulnerability. I don't see it exactly in Snyk, though there is a moderate vulnerability that suggests upgrading to axios 1.12.0. The suggested fix for the high vulnerability locally is upgrading from axios 1.0.0 to 1.11.0.

@bwang-icf bwang-icf marked this pull request as ready for review December 15, 2025 19:20
Copy link

@JamesDemeryNava JamesDemeryNava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I believe these PRs need to be approved @sb-DarenDean or @sb-benohe, but I think it's good to go.

@sb-DarenDean
Copy link

This looks good to me!

@sb-benohe sb-benohe merged commit 80b6be0 into main Dec 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants