Skip to content

🔒 Fix command injection vulnerability in get_files #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjzegmott merged 1 commit into from
May 20, 2026
Merged

🔒 Fix command injection vulnerability in get_files #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dtcli/src/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import os
import re
import shutil
import subprocess
import time
from collections import defaultdict
from pathlib import Path
Expand Down Expand Up @@ -297,8 +298,8 @@ def get_files(
if site == "canfar":
for folder in folders:
os.makedirs(folder, exist_ok=True)
os.system(f"chgrp -R chime-frb-rw {folder}") # nosec
os.system(f"chmod -R g+w {folder}") # nosec
subprocess.run(["chgrp", "-R", "chime-frb-rw", folder])
subprocess.run(["chmod", "-R", "g+w", folder])
Comment on lines +301 to +302
Comment on lines 298 to +302
else:
for folder in folders:
os.makedirs(folder, exist_ok=True)
Expand Down
Loading