Skip to content

🧹 Refactor invalid certificate handling in cadcclient #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tjzegmott wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🧹 Refactor invalid certificate handling in cadcclient #153

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50aa653
Refactor invalid certificate handling in cadcclient
google-labs-jules[bot] May 19, 2026
4468772
Refactor invalid certificate handling in cadcclient
google-labs-jules[bot] May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions dtcli/utilities/cadcclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,13 @@ def _connect(
storage = StorageInventoryClient(cert, resource_id=storage_resource_id)
query = CadcTapClient(cert, resource_id=query_resource_id)
return cert, storage, query
# TODO: Handle invalid cert
except ValueError as error:
logger.error(error)
raise error
logger.error(
"Authorization failed: The provided CANFAR certificate is "
"invalid or expired. Please ensure you have a valid "
"certificate and try again."
)
raise ValueError("Invalid or expired CANFAR certificate.") from error


def get(
Expand Down
Loading