-
Notifications
You must be signed in to change notification settings - Fork 49
Developing of Doppler velocity simulator #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuhi-n
wants to merge
23
commits into
CFMIP:master
Choose a base branch
from
yuhi-n:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@yuhi-n This is exciting. While we are getting specialists to review the code please resolve the conflicts with COSP, which was recently updated to include another simulator. |
|
@yuhi-n thanks for opening this PR. Is there any publication that documents this Doppler simulator? If so, please could you add a link in the description above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Yuhi Nakamura, AORI, the University of Tokyo. I am a member of Japanese EarthCARE project team.
Prof. Kenta Suzuki and I are developing new simulator code to accommodate Doppler velocity observation by EarthCARE CPR.
I am submitting this request to have my code reviewed and merged into COSP2.
This is an extension of the quickbeam routine to calculate Doppler velocity and spectrum width. Statistics is provided separately for stratiform and convective clouds because vertical air motion is differently obtained in a typical GCM.
I am providing test dataset generated by MIROC6 and python notebooks for visualization.
Could you please review our codes and provide comments so that the new observation can be utilized for evaluating climate models?
Thank you for your all effort on review processes.