-
Notifications
You must be signed in to change notification settings - Fork 49
Run CI in Docker containers #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…name used in subsequent step. Otherwise, package is not published.
|
@RobertPincus great work! I am interested in understanding some of the details when there is time. Essentially, how is this different from the containerized CI that existed previously? I say pull this in and I'll create a new PR for the RTTOV testing. It looks like there are containerized gfortran and ifx now so COSP-RTTOV can be tested in both of them? |
|
@jshaw35 This PR changes to Docker containers built from files in the COSP repo rather than relying on containers built for another purpose. That means both that we don't need to install the Python packages on the fly. More importantly the COSP containers include the RTTOV libraries in Another change is that |
|
Mmmm @alejandrobodas @jshaw35 We are using the same KGOs for all compilers, and it looks like difference using |
|
@RobertPincus, I agree this looks like a compiler change. As a note, the dbze94 variable has often appeared to be the most susceptible to compiler changes. This makes me wonder if this has something to do with the code itself. |
This PR includes a set of Dockerfiles to create Docker containers with all the software needed to run the continuous integration and a change use those containers in the CI.
We could merge now and then make another PR to to include tests of RTTOV in the CI, or Jonah could work on
.github/workflows/containerized-ci.ymlnow and we make a single PR.Will we retain the bare-metal CI once we're using containers? Do we want to extend this to include other compilers?
@jshaw35 @dustinswales @alejandrobodas