feat(facets): parametrize RangeFacet#692
feat(facets): parametrize RangeFacet#692zubeydecivelek wants to merge 1 commit intoCERNDocumentServer:masterfrom
Conversation
zubeydecivelek
force-pushed
the
date-facet
branch
from
8932eaf to
a9ed124
Compare
zubeydecivelek
changed the title
| "InvenioRdmRecords.PublishModal.container": PublishModalComponent, | ||
| "InvenioRequests.LockRequest": LockRequestComponent, | ||
| "InvenioAppRdm.RecordVersionsList.Item.container": RecordVersionItemContent, | ||
| RangeFacet: CDSRangeFacet, |
There was a problem hiding this comment.
Is this missing the full name? I'm not sure what the full name should be but it's something like [${appName}.RangeFacet.element\] right?
There was a problem hiding this comment.
This is intentional. We are overriding the full RangeFacet component (registered via Overridable.component("RangeFacet", …) see here) so we can parametrize its behavior.
RangeFacet.element is a separate internal override point, which it's not the target here(we want to customize the optional filters only).
There was a problem hiding this comment.
Ahhh okay, but shouldn't RangeFacet at least be "RangeFacet"? I can't see the variable RangeFacet defined anywhere in this file
|
Since default and custom ranges will be enabled by default, see, this is not needed |
2 participants
needs:
should be merge after these PR's