Skip to content

Fixup GAS/binutils assembly#762

Merged
ZERICO2005 merged 7 commits intomasterfrom
fixup_asm
Apr 2, 2026
Merged

Fixup GAS/binutils assembly#762
ZERICO2005 merged 7 commits intomasterfrom
fixup_asm

Conversation

@ZERICO2005
Copy link
Copy Markdown
Contributor

@ZERICO2005 ZERICO2005 commented Mar 23, 2026

Bug fixes:

  • added missing @function from .global/.weak, this is necessary for preventing these warnings from binutils:
toolchain/CEdev/binutils/bin/z80-none-elf-ld: warning: strcmp.o: missing .note.GNU-stack section implies executable stack
toolchain/CEdev/binutils/bin/z80-none-elf-ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
  • removed @function from .local
  • fixed extern --> .extern
  • fixed section --> .section

Formatting:

  • canonicalized the order of @function declarations (so .type _func, @function is always after its corresponding .global/.weak _func.
  • Enforce using 0x012345/$012345 instead of 0012345h
  • fixed .assumes to assumes in comments
  • switched ADL=1, adl = 1, and etc to adl=1 so everything is consistent toolchain wide.

@ZERICO2005
Copy link
Copy Markdown
Contributor Author

I think I will deal with .L__label, L__label, and .local _func \ .type _func, @function in a separate PR

@ZERICO2005 ZERICO2005 merged commit 00f7aa9 into master Apr 2, 2026
9 checks passed
@ZERICO2005 ZERICO2005 deleted the fixup_asm branch April 2, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant