Skip to content

fix GetFontByStyle carry flag bug #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateoconlechuga merged 1 commit into from
Feb 12, 2026
Merged

fix GetFontByStyle carry flag bug #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions src/fontlibc/fontlibc.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1990,34 +1990,33 @@ fontlib_GetFontByStyleRaw:
.badFont:
pop ix
ret

.checkStyle:
ld a,(ix + strucFont.height)
cp (iy + arg1)
cp a, (iy + arg1)
ccf
ret nc
cp (iy + arg2)
cp a, (iy + arg2)
jr z,.sizeOK
ret nc
.sizeOK:
ld a,(ix + strucFont.weight)
cp (iy + arg3)
cp a, (iy + arg3)
ccf
ret nc
cp (iy + arg4)
cp a, (iy + arg4)
jr z,.weightOK
ret nc
.weightOK:
; TODO: I think the CP here might sometimes SET carry when it shouldn't be?
ld a,(ix + strucFont.style)
ld c,(iy + arg5)
and a,c
cp a,c
ld c, (ix + strucFont.style)
ld a, (iy + arg5)
; test for required set bits
and a, c
xor a, c
ret nz
ld a,(ix + strucFont.style)
ld c,(iy + arg6)
and a,c
xor a,c
cp a,c
ld a, (iy + arg6)
; test for required cleared bits
and a, c
ret nz
scf
ret
Expand Down
Loading