CCSMB-15: Wide Printer Format (2dj) and Wide Printer Format Array (2dja) Formats and CCSMB-16: 3D Print JSON (3dj) #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaKnijn
requested changes
Mar 30, 2024
Member
EmmaKnijn
left a comment
EmmaKnijn
left a comment
There was a problem hiding this comment.
Looks good, just change the titles and you'll be good
EmmaKnijn
approved these changes
Mar 30, 2024
Member
|
LGTM, as its just an import |
EmmaKnijn
added
kind: import from external source
tomodachi94
requested changes
Mar 30, 2024
Member
tomodachi94
left a comment
tomodachi94
left a comment
There was a problem hiding this comment.
Lgtm, just some minor corrections and a few points that should probably be addressed.
Co-authored-by: Tomo <68489118+tomodachi94@users.noreply.github.com>
Co-authored-by: Tomo <68489118+tomodachi94@users.noreply.github.com>
ShreksHellraiser
left a comment
ShreksHellraiser
left a comment
There was a problem hiding this comment.
The formatting mistake in CCSMB-16 should be corrected, and see my comment on CCSMB-15. Once the formatting mistake is corrected I think it is good to merge.
tomodachi94
approved these changes
Nov 28, 2024
scmcgowen
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFCs for 2dj, 2dja, and 3dj files. Suggestions welcome!