Fix Averaging and Conformational Analysis for Protein Multimers#162
Merged
Fix Averaging and Conformational Analysis for Protein Multimers#162
Conversation
harryswift01
approved these changes
Sep 26, 2025
Member
harryswift01
left a comment
There was a problem hiding this comment.
Thanks for spotting and fixing this, it looks like we now correctly handle averaging for larger molecules and no longer skip dihedral and conformational calculations at the residue level. I also appreciate the addition of the documentation and updated tests. Happy for this to be merged into main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is to fix issue #161 where a protein tetramer gave a Value Error with an inhomogenous shape for the conformational states array.
Changes
Change 1
Change 2
Change 3
Impact