Use --internal-ip-network if provided #93
Merged
+63
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsks
force-pushed
the
fix/port-forwarding
branch
from
c807a64 to
ae644be
Compare
Member
Author
|
I will update this shortly with working tests. |
larsks
force-pushed
the
fix/port-forwarding
branch
4 times, most recently
from
25eadd3 to
515084a
Compare
Previously, if --internal-ip-network was provided, we would find ports on the wrong network because we were only searching for ports by address. With this change, ports must match both the address and the network in order to be considered.
larsks
force-pushed
the
fix/port-forwarding
branch
from
515084a to
ee6bc0e
Compare
ajamias
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if --internal-ip-network was provided, we would find ports on
the wrong network because we were only searching for ports by address. With
this change, ports must match both the address and the network in order to
be considered.