Fix the baremetal microversion issue #86
Conversation
larsks
left a comment
larsks
left a comment
There was a problem hiding this comment.
Please add a commit message and pull request description. What issue does this address? How does it implement the correction?
skanthed
force-pushed
the
fix-api-micorversion
branch
3 times, most recently
from
b160a0e to
0988ec4
Compare
tzumainn
left a comment
tzumainn
left a comment
There was a problem hiding this comment.
Looks reasonable to me - I tried moving the if statement into various places, and can confirm that none of it works elsewhere. There is almost definitely a more elegant solution somewhere, but I think that may require digging deep into the openstackclient code.
|
@skanthed you may want to squash the commits to get rid of the merge commit, though |
skanthed
force-pushed
the
fix-api-micorversion
branch
from
d0de0a6 to
96b1433
Compare
|
@tzumainn Squashed it! |
|
Ah, I think you may have to rebase from master first! It looks like the ubuntu OS update is manually applied here. |
|
And please copy the PR description to the commit message, which is still empty. |
Sets the default OS_BAREMETAL_API_VERSION earlier in plugin.py to ensure it's applied before OpenStackClient initializes. Fixes microversion mismatch by preventing fallback to unsupported default (1.95) during CLI execution.
skanthed
force-pushed
the
fix-api-micorversion
branch
from
96b1433 to
0f74691
Compare
3 participants
Sets the default
OS_BAREMETAL_API_VERSIONearlier in plugin.py to ensure it's applied before OpenStackClient initializes.Fixes microversion mismatch by preventing fallback to unsupported default (1.95) during CLI execution.