Make "esi mdc baremetal node list" work #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This PR was sort of an accident, because I was looking at setup.cfg and found myself asking, "what the heck is this |
OpenStackConfig.get_all() will fail with a keystone exception if there are any OS_* variables set in the environment [1]. This is easy to trigger if, for example, you have set OS_BAREMETAL_API_VERSION in your environment to work around [2]. We can avoid the problem by removing the call to get_all(), and instead initializing the list of clouds using get_cloud_names(). This commit makes a number of additional changes to esiclient/v1/mdc/mdc_node_baremetal.py: - Several attribute names appear to have changed since this code was written (node.uuid is now node.id; node.instance_uuid is now node.instance_id). - Replace single-letter variable names with more meaningful names. - Add the '--ignore-invalid' command, which allows the command to continue in the event that it cannot successfully connect to one or more clouds. [1]: https://bugs.launchpad.net/openstacksdk/+bug/2096621 [2]: CCI-MOC/esi#669
|
@tzumainn saw this while I was reviewing PRs. |
Contributor
|
@larsks Oh, ha, it was a sort of experimental thing created in the wilder days of ESI that has never become useful. I like your changes; however I also think maybe this code should just be removed as irrelevant - what do you think? |
Member
Author
|
I guess I would say (a) merge this code then (b) submit a new pr removing the command. This way the fixed code exists if somebody ever wants to go looking for it. |
Contributor
|
sounds good! |
tzumainn
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenStackConfig.get_all() will fail with a keystone exception if there are
any OS_* variables set in the environment 1. This is easy to trigger if,
for example, you have set OS_BAREMETAL_API_VERSION in your environment to
work around 2.
We can avoid the problem by removing the call to get_all(), and
instead initializing the list of clouds using get_cloud_names().
This commit makes a number of additional changes to
esiclient/v1/mdc/mdc_node_baremetal.py:
Several attribute names appear to have changed since this code was
written (node.uuid is now node.id; node.instance_uuid is now
node.instance_id).
Replace single-letter variable names with more meaningful names.
Add the '--ignore-invalid' command, which allows the command to continue
in the event that it cannot successfully connect to one or more clouds.