Skip to content

Conversation

@cfsmp3
Copy link
Contributor

@cfsmp3 cfsmp3 commented Jan 18, 2026

Summary

  • Fix the deployment workflow so manual triggers actually work

Problem

The deploy job had this condition:

if: ${{ github.event.workflow_run.conclusion == 'success' }}

This only works for workflow_run events. When triggered manually via workflow_dispatch:

  • github.event.workflow_run is undefined
  • The condition evaluates to false
  • The job is skipped

Fix

if: ${{ github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success' }}

Now deployment runs if:

  • Manually triggered (workflow_dispatch), OR
  • Auto-triggered by successful test workflow (workflow_run)

Test plan

  • Merge this PR
  • Run gh workflow run "Deploy sample platform" --repo CCExtractor/sample-platform
  • Verify deployment succeeds (not skipped)

🤖 Generated with Claude Code

The deploy job condition only checked for workflow_run success,
which meant manual triggers via workflow_dispatch were always skipped.

Now the job runs if either:
- Manually triggered (workflow_dispatch), OR
- Triggered by successful "Run tests and code checks" workflow

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@sonarqubecloud
Copy link

@cfsmp3 cfsmp3 merged commit 3679ea8 into master Jan 18, 2026
6 checks passed
@cfsmp3 cfsmp3 deleted the fix/workflow-dispatch-condition branch January 18, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants