Skip to content

Conversation

@cfsmp3
Copy link
Collaborator

@cfsmp3 cfsmp3 commented Jan 21, 2026

Summary

  • Frontend fetch calls to task API endpoints were missing credentials: 'include'
  • The auth middleware added in PR security: inject session credentials into API requests #408 requires session cookies on all protected endpoints
  • Without credentials, requests return 401 "Authentication required", causing tasks not to display in the UI

Files Changed

  • frontend/src/components/HomeComponents/Tasks/hooks.ts - Added credentials: 'include' to fetchTaskwarriorTasks, addTaskToBackend, editTaskOnBackend, modifyTaskOnBackend
  • frontend/src/components/HomeComponents/Tasks/tasks-utils.ts - Added credentials: 'include' to markTaskAsCompleted, bulkMarkTasksAsCompleted, bulkMarkTasksAsDeleted, markTaskAsDeleted

Test plan

  • Log in to the frontend
  • Verify tasks are displayed correctly
  • Add a new task and verify it appears
  • Complete/delete a task and verify it updates

🤖 Generated with Claude Code

The auth middleware added in PR #408 requires session cookies on all
task API endpoints. Frontend fetch calls were missing credentials:
'include', causing 401 errors when fetching/modifying tasks.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants