Skip to content

refactore: Implement marker bit validation with debug output in user data parsing. #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AhmedAlian7 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

refactore: Implement marker bit validation with debug output in user data parsing. #2113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGES.TXT
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- Fix: Delete empty output files instead of leaving 0-byte files (#1282)
- Fix: --mkvlang now supports BCP 47 language tags (e.g., en-US, zh-Hans-CN) and multiple codes
- Fix: segmentation fault when using --multiprogram
- Fix: Add syntax check for SCTE 20 marker bit to prevent incorrect parsing of corrupt streams

0.96.5 (2026-01-05)
-------------------
Expand Down
5 changes: 4 additions & 1 deletion src/lib_ccx/es_userdata.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,10 @@ int user_data(struct encoder_ctx *enc_ctx, struct lib_cc_decode *dec_ctx, struct
skip_bits(ustream, 5); // line_offset - unused
cc_data1 = (unsigned int)read_bits(ustream, 8);
cc_data2 = (unsigned int)read_bits(ustream, 8);
read_bits(ustream, 1); // TODO: Add syntax check */
if (read_bits(ustream, 1) == 0)
{
dbg_print(CCX_DMT_VERBOSE, "SCTE 20: Marker bit is 0 (should be 1)\n");
}

if (ustream->bitsleft < 0)
fatal(CCX_COMMON_EXIT_BUG_BUG, "In user_data: ustream->bitsleft < 0. Cannot continue.");
Expand Down
Loading