[FEAT] WIP module `decoder_isdb` in lib_ccxr by vatsalkeshav · Pull Request #1676 · CCExtractor/ccextractor

vatsalkeshav · 2025-03-16T01:44:32Z

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

This PR migrates /src/lib_ccx/ccx_decoders_isdb.c to rust.
These changes have been made-

Pure rust equivalent functions in /src/rust/lib_ccxr/src/decoder_isdb/functions_isdb.rs, functions_common.rs
Required datatypes in /src/rust/lib_ccxr/src/decoder_isdb/structs_xds.rs, structs_isdb.rs , structs_ccdecode.rs(thanks @steel-bucket)
Exit codes etc in /src/rust/lib_ccxr/src/decoder_isdb/exit_codes.rs
C-compatible rust functions/exports in src/rust/src/libccxr_exports/isdb_exports.rs
Declaration and use of written rust functions in /src/lib_ccx/ccx_decoders_isdb.c

ccextractor-bot · 2025-03-16T01:56:26Z

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 9e2a594...:

Report Name	Tests Passed
Broken	0/13
CEA-708	0/14
DVB	0/7
DVD	0/3
DVR-MS	0/2
General	0/27
Hauppage	0/3
MP4	0/3
NoCC	0/10
Options	0/86
Teletext	0/21
WTV	0/13
XDS	0/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

ccextractor --autoprogram --out=srt --latin1 1d9731bd80..., Last passed: Test 5519
ccextractor --out=sami --latin1 --autoprogram 5b4e0a6034..., Last passed: Test 5519
ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 8e8229b88b..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 7236304cfc..., Last passed: Test 5519
ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed: Test 5519
ccextractor --out=srt --latin1 06b3a9237d..., Last passed: Test 5519
ccextractor --out=srt --latin1 83f8cceb74..., Last passed: Test 5519
ccextractor --out=srt --latin1 611b4a9235..., Last passed: Test 5519
ccextractor --out=srt --latin1 b46e9e8e3f..., Last passed: Test 5519
ccextractor --out=srt --latin1 89e417e622..., Last passed: Test 5519
ccextractor --out=srt --latin1 d59eadc4ed..., Last passed: Test 5519
ccextractor --out=srt --latin1 4d4e938ef6..., Last passed: Test 5519
ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed: Test 5519
ccextractor --service 1 --out=txt f17524b53f..., Last passed: Test 5519
ccextractor --service 1 --out=txt da904de35d..., Last passed: Test 5519
ccextractor --service 1 --out=txt 80848c45f8..., Last passed: Test 5519
ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed: Test 5519
ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed: Test 5519
ccextractor --service 1 --out=srt da904de35d..., Last passed: Test 5519
ccextractor --service 1 --out=sami da904de35d..., Last passed: Test 5519
ccextractor --service 1 --out=ttxt da904de35d..., Last passed: Test 5519
ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed: Test 5519
ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed: Test 5519
ccextractor --service all da904de35d..., Last passed: Test 5519
ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed: Test 5519
ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 1020459a86..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed: Test 5519
ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 85271be4d2..., Last passed: Test 5519
ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed: Test 5519
ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 5ae2007a79..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 1e44efd810..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 add511677c..., Last passed: Test 5519
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 acf871cbfd..., Last passed: Test 5519
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 5cbb21adb6..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 9a496d3828..., Last passed: Test 5519
ccextractor --out=srt --latin1 --autoprogram 56c9f34548..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 e9b9008fdf..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 c032183ef0..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 27e46255f0..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 d037c7509e..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 1974a299f0..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 b22260d065..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7aad20907e..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla c41f73056a..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla 5d3a29f9f8..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla 70000200c0..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla 6dc772d881..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla adce82fd39..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla 15feae9133..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla 95dd33c6f1..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 01509e4d27..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla ab9cf8cfad..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 15feae9133..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 5d3a29f9f8..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 c41f73056a..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --sentencecap c032183ef0..., Last passed: Test 5519
ccextractor --autoprogram --out=bin --latin1 c032183ef0..., Last passed: Test 5519
ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b..., Last passed: Test 5519
ccextractor --hauppauge --autoprogram --out=srt --latin1 a03b5b2a56..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --hauppauge --latin1 553d78e755..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --hauppauge --ucla --latin1 553d78e755..., Last passed: Test 5519
ccextractor --in=mp4 --out=srt --latin1 b2771c84c2..., Last passed: Test 5519
ccextractor --in=mp4 --out=srt --latin1 5df914ce77..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --bom --latin1 8849331dda..., Last passed: Test 5519
ccextractor --mp4vidtrack --autoprogram --out=ttxt --latin1 adc0a818c3..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 08bdf0e2c1..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 bee139671a..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 3842d00925..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 80af83c038..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 837b02f722..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 41dab6b2a7..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 4b117b4d66..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 26ee6add4d..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds fca0dce412..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --output-field 1 a65d39ccb3..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --output-field 2 a65d39ccb3..., Last passed: Test 5519
ccextractor --autoprogram c83f765c66..., Last passed: Test 5519
ccextractor --service 1 c83f765c66..., Last passed: Test 5519
ccextractor --in=ts c83f765c66..., Last passed: Test 5519
ccextractor --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --out=sami c83f765c66..., Last passed: Test 5519
ccextractor --out=dvdraw c83f765c66..., Last passed: Test 5519
ccextractor --out=txt c83f765c66..., Last passed: Test 5519
ccextractor --out=ttxt c83f765c66..., Last passed: Test 5519
ccextractor --out=smptett c83f765c66..., Last passed: Test 5519
ccextractor --out=spupng c83f765c66..., Last passed: Test 5519
ccextractor --goptime c83f765c66..., Last passed: Test 5519
ccextractor --no-goptime c83f765c66..., Last passed: Test 5519
ccextractor --fixpadding c83f765c66..., Last passed: Test 5519
ccextractor --90090 c83f765c66..., Last passed: Test 5519
ccextractor --myth c83f765c66..., Last passed: Test 5519
ccextractor --program-number 1 c83f765c66..., Last passed: Test 5519
ccextractor --datapid 256 c83f765c66..., Last passed: Test 5519
ccextractor --datastreamtype 2 c83f765c66..., Last passed: Test 5519
ccextractor --datastreamtype 2 --streamtype 2 c83f765c66..., Last passed: Test 5519
ccextractor --no-autotimeref c83f765c66..., Last passed: Test 5519
ccextractor --bom c83f765c66..., Last passed: Test 5519
ccextractor --no-bom c83f765c66..., Last passed: Test 5519
ccextractor --unicode c83f765c66..., Last passed: Test 5519
ccextractor --utf8 c83f765c66..., Last passed: Test 5519
ccextractor --latin1 c83f765c66..., Last passed: Test 5519
ccextractor --no-fontcolor c83f765c66..., Last passed: Test 5519
ccextractor --no-typesetting c83f765c66..., Last passed: Test 5519
ccextractor --trim c83f765c66..., Last passed: Test 5519
ccextractor --sentencecap c83f765c66..., Last passed: Test 5519
ccextractor --capfile /repository/Dictionary/MattS_dictionary.txt c83f765c66..., Last passed: Test 5519
ccextractor --unixts 5 --out=txt c83f765c66..., Last passed: Test 5519
ccextractor --out=txt --datets c83f765c66..., Last passed: Test 5519
ccextractor --out=txt --sects c83f765c66..., Last passed: Test 5519
ccextractor --out=txt --lf c83f765c66..., Last passed: Test 5519
ccextractor --autodash --trim c83f765c66..., Last passed: Test 5519
ccextractor --bufferinput c83f765c66..., Last passed: Test 5519
ccextractor --no-bufferinput c83f765c66..., Last passed: Test 5519
ccextractor --buffersize 1M c83f765c66..., Last passed: Test 5519
ccextractor --dru c83f765c66..., Last passed: Test 5519
ccextractor --no-rollup c83f765c66..., Last passed: Test 5519
ccextractor --ru1 c83f765c66..., Last passed: Test 5519
ccextractor --ru2 c83f765c66..., Last passed: Test 5519
ccextractor --ru3 c83f765c66..., Last passed: Test 5519
ccextractor --delay 200 c83f765c66..., Last passed: Test 5519
ccextractor --startat 4 --endat 7 c83f765c66..., Last passed: Test 5519
ccextractor --no-codec dvbsub c83f765c66..., Last passed: Test 5519
ccextractor --debug --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --608 --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --708 --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --goppts --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --xdsdebug --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --vides --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --cbraw --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --no-sync --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --fullbin --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --parsedebug --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --parsePAT --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --parsePMT --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --investigate-packets --out=srt c83f765c66..., Last passed: Test 5519
ccextractor --in=ps e9b9008fdf..., Last passed: Test 5519
ccextractor --in=es dc7169d7c4..., Last passed: Test 5519
ccextractor --in=asf 6395b281ad..., Last passed: Test 5519
ccextractor --in=wtv b46e9e8e3f..., Last passed: Test 5519
ccextractor --in=bin 988d4e8bba..., Last passed: Test 5519
ccextractor --in=raw fb79021542..., Last passed: Test 5519
ccextractor --in=mp4 b2771c84c2..., Last passed: Test 5519
ccextractor --mp4vidtrack 5df914ce77..., Last passed: Test 5519
ccextractor --wtvconvertfix acf871cbfd..., Last passed: Test 5519
ccextractor --wtvmpeg2 10f0f77cf4..., Last passed: Test 5519
ccextractor --hauppauge d6df1b227a..., Last passed: Test 5519
ccextractor --xmltv --out=null 96efd279cf..., Last passed: Test 5519
ccextractor --codec dvbsub --out=spupng 85271be4d2..., Last passed: Test 5519
ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5519
ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5519
ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5519
ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5519
ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5519
ccextractor --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 5519
ccextractor --endcreditsforatleast 3 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 5519
ccextractor --endcreditsforatmost 2 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 5519
ccextractor --tpage 801 4e56e88ba4..., Last passed: Test 5519
ccextractor --tverbose 4e56e88ba4..., Last passed: Test 5519
ccextractor --teletext 4e56e88ba4..., Last passed: Test 5519
ccextractor --out=txt --ucla c83f765c66..., Last passed: Test 5519
ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 4e56e88ba4..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 006fdc391a..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 b37ce60eb9..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 297a44921a..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 efbe129086..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 eae0077731..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 8c1615c1a8..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 c6407fb294..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --tpage 299 44c45593fb..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --tpage 299 b8c55aa2e9..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 b236a0590b..., Last passed: Test 5519
ccextractor --out=srt --latin1 f23a544ba8..., Last passed: Test 5519
ccextractor --out=srt --latin1 97cc394d87..., Last passed: Test 5519
ccextractor --out=srt --latin1 10f0f77cf4..., Last passed: Test 5519
ccextractor --out=srt --latin1 df3b4d62d3..., Last passed: Test 5519
ccextractor --out=srt --latin1 d7e7dbdf68..., Last passed: Test 5519
ccextractor --out=srt --latin1 76734ac4a7..., Last passed: Test 5519
ccextractor --out=srt --latin1 c791382c94..., Last passed: Test 5519
ccextractor --out=srt --latin1 f673b2f916..., Last passed: Test 5519
ccextractor --out=srt --latin1 da75bdee47..., Last passed: Test 5519
ccextractor --out=srt --latin1 bd6f33a669..., Last passed: Test 5519
ccextractor --out=srt --latin1 0e5e6b26be..., Last passed: Test 5519
ccextractor --out=srt --latin1 a226cc302d..., Last passed: Test 5519
ccextractor --out=srt --latin1 ae6327683e..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 725a49f871..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla d037c7509e..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --ucla d037c7509e..., Last passed: Test 5519
ccextractor --autoprogram --out=smptett --latin1 --ucla e274a73653..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla e274a73653..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla 85058ad37e..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b22260d065..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --ucla b22260d065..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --xds --ucla c813e713a0..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --ucla c813e713a0..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 27fab4dbb6..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --ucla 27fab4dbb6..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds bbd5bb52fc..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --ucla bbd5bb52fc..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b992e0cccb..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds d0291cdcf6..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7d2730d38e..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --ucla 7d2730d38e..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds c8dc039a88..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --ucla c8dc039a88..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 53339f3455..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --ucla 53339f3455..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 83b03036a2..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --ucla 83b03036a2..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7d3f25c32c..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --ucla 7d3f25c32c..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds f41d4c29a1..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --ucla f41d4c29a1..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 88cd42b89a..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --ucla 88cd42b89a..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --output-field 2 --ucla 88cd42b89a..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7f41299cc7..., Last passed: Test 5519
ccextractor --autoprogram --out=srt --latin1 --ucla 7f41299cc7..., Last passed: Test 5519
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 0069dffd21..., Last passed: Test 5519

Check the result page for more info.

ccextractor-bot · 2025-03-29T17:29:14Z

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit b62027a...:

Report Name	Tests Passed
Broken	13/13
CEA-708	14/14
DVB	7/7
DVD	3/3
DVR-MS	2/2
General	27/27
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	79/86
Teletext	21/21
WTV	13/13
XDS	34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

ccextractor --autoprogram --out=srt --latin1 --output-field 1 a65d39ccb3..., Last passed: Test 5581
ccextractor --out=ttxt c83f765c66..., Last passed: Test 5581
ccextractor --out=spupng c83f765c66..., Last passed: Test 5581
ccextractor --goptime c83f765c66..., Last passed: Test 5581
ccextractor --unicode c83f765c66..., Last passed: Test 5581
ccextractor --no-codec dvbsub c83f765c66..., Last passed: Test 5581
ccextractor --in=es dc7169d7c4..., Last passed: Test 5519

Congratulations: Merging this PR would fix the following tests:

ccextractor --autoprogram --out=srt --latin1 1d9731bd80..., Last passed: Test 5581
ccextractor --out=sami --latin1 --autoprogram 5b4e0a6034..., Last passed: Test 5581
ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 8e8229b88b..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 7236304cfc..., Last passed: Test 5581
ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed: Test 5581
ccextractor --out=srt --latin1 06b3a9237d..., Last passed: Test 5581
ccextractor --out=srt --latin1 83f8cceb74..., Last passed: Test 5581
ccextractor --out=srt --latin1 611b4a9235..., Last passed: Test 5581
ccextractor --out=srt --latin1 b46e9e8e3f..., Last passed: Test 5581
ccextractor --out=srt --latin1 89e417e622..., Last passed: Test 5581
ccextractor --out=srt --latin1 d59eadc4ed..., Last passed: Test 5581
ccextractor --out=srt --latin1 4d4e938ef6..., Last passed: Test 5581
ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed: Test 5581
ccextractor --service 1 --out=txt f17524b53f..., Last passed: Test 5581
ccextractor --service 1 --out=txt da904de35d..., Last passed: Test 5581
ccextractor --service 1 --out=txt 80848c45f8..., Last passed: Test 5581
ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed: Test 5581
ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed: Test 5581
ccextractor --service 1 --out=srt da904de35d..., Last passed: Test 5581
ccextractor --service 1 --out=sami da904de35d..., Last passed: Test 5581
ccextractor --service 1 --out=ttxt da904de35d..., Last passed: Test 5581
ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed: Test 5581
ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed: Test 5581
ccextractor --service all da904de35d..., Last passed: Test 5581
ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed: Test 5581
ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 1020459a86..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed: Test 5581
ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 85271be4d2..., Last passed: Test 5581
ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed: Test 5581
ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 5ae2007a79..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 1e44efd810..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 add511677c..., Last passed: Test 5581
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 acf871cbfd..., Last passed: Test 5581
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 5cbb21adb6..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 9a496d3828..., Last passed: Test 5581
ccextractor --out=srt --latin1 --autoprogram 56c9f34548..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 e9b9008fdf..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 c032183ef0..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 27e46255f0..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 d037c7509e..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 1974a299f0..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 b22260d065..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7aad20907e..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla c41f73056a..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla 5d3a29f9f8..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla 70000200c0..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla 6dc772d881..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla adce82fd39..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla 15feae9133..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla 95dd33c6f1..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 01509e4d27..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla ab9cf8cfad..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 15feae9133..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 5d3a29f9f8..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 c41f73056a..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --sentencecap c032183ef0..., Last passed: Test 5581
ccextractor --autoprogram --out=bin --latin1 c032183ef0..., Last passed: Test 5581
ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b..., Last passed: Test 5581
ccextractor --hauppauge --autoprogram --out=srt --latin1 a03b5b2a56..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --hauppauge --latin1 553d78e755..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --hauppauge --ucla --latin1 553d78e755..., Last passed: Test 5581
ccextractor --in=mp4 --out=srt --latin1 b2771c84c2..., Last passed: Test 5581
ccextractor --in=mp4 --out=srt --latin1 5df914ce77..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --bom --latin1 8849331dda..., Last passed: Test 5581
ccextractor --mp4vidtrack --autoprogram --out=ttxt --latin1 adc0a818c3..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 08bdf0e2c1..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 bee139671a..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 3842d00925..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 80af83c038..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 837b02f722..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 41dab6b2a7..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 4b117b4d66..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 26ee6add4d..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds fca0dce412..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --output-field 2 a65d39ccb3..., Last passed: Test 5581
ccextractor --autoprogram c83f765c66..., Last passed: Test 5581
ccextractor --service 1 c83f765c66..., Last passed: Test 5581
ccextractor --in=ts c83f765c66..., Last passed: Test 5581
ccextractor --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --out=sami c83f765c66..., Last passed: Test 5581
ccextractor --out=dvdraw c83f765c66..., Last passed: Test 5581
ccextractor --out=txt c83f765c66..., Last passed: Test 5581
ccextractor --out=smptett c83f765c66..., Last passed: Test 5581
ccextractor --no-goptime c83f765c66..., Last passed: Test 5581
ccextractor --fixpadding c83f765c66..., Last passed: Test 5581
ccextractor --90090 c83f765c66..., Last passed: Test 5581
ccextractor --myth c83f765c66..., Last passed: Test 5581
ccextractor --program-number 1 c83f765c66..., Last passed: Test 5581
ccextractor --datapid 256 c83f765c66..., Last passed: Test 5581
ccextractor --datastreamtype 2 c83f765c66..., Last passed: Test 5581
ccextractor --datastreamtype 2 --streamtype 2 c83f765c66..., Last passed: Test 5581
ccextractor --no-autotimeref c83f765c66..., Last passed: Test 5581
ccextractor --bom c83f765c66..., Last passed: Test 5581
ccextractor --no-bom c83f765c66..., Last passed: Test 5581
ccextractor --utf8 c83f765c66..., Last passed: Test 5581
ccextractor --latin1 c83f765c66..., Last passed: Test 5581
ccextractor --no-fontcolor c83f765c66..., Last passed: Test 5581
ccextractor --no-typesetting c83f765c66..., Last passed: Test 5581
ccextractor --trim c83f765c66..., Last passed: Test 5581
ccextractor --sentencecap c83f765c66..., Last passed: Test 5581
ccextractor --capfile /repository/Dictionary/MattS_dictionary.txt c83f765c66..., Last passed: Test 5581
ccextractor --unixts 5 --out=txt c83f765c66..., Last passed: Test 5581
ccextractor --out=txt --datets c83f765c66..., Last passed: Test 5581
ccextractor --out=txt --sects c83f765c66..., Last passed: Test 5581
ccextractor --out=txt --lf c83f765c66..., Last passed: Test 5581
ccextractor --autodash --trim c83f765c66..., Last passed: Test 5581
ccextractor --bufferinput c83f765c66..., Last passed: Test 5581
ccextractor --no-bufferinput c83f765c66..., Last passed: Test 5581
ccextractor --buffersize 1M c83f765c66..., Last passed: Test 5581
ccextractor --dru c83f765c66..., Last passed: Test 5581
ccextractor --no-rollup c83f765c66..., Last passed: Test 5581
ccextractor --ru1 c83f765c66..., Last passed: Test 5581
ccextractor --ru2 c83f765c66..., Last passed: Test 5581
ccextractor --ru3 c83f765c66..., Last passed: Test 5581
ccextractor --delay 200 c83f765c66..., Last passed: Test 5581
ccextractor --startat 4 --endat 7 c83f765c66..., Last passed: Test 5581
ccextractor --debug --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --608 --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --708 --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --goppts --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --xdsdebug --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --vides --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --cbraw --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --no-sync --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --fullbin --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --parsedebug --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --parsePAT --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --parsePMT --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --investigate-packets --out=srt c83f765c66..., Last passed: Test 5581
ccextractor --in=ps e9b9008fdf..., Last passed: Test 5581
ccextractor --in=asf 6395b281ad..., Last passed: Test 5581
ccextractor --in=wtv b46e9e8e3f..., Last passed: Test 5581
ccextractor --in=bin 988d4e8bba..., Last passed: Test 5581
ccextractor --in=raw fb79021542..., Last passed: Test 5581
ccextractor --in=mp4 b2771c84c2..., Last passed: Test 5581
ccextractor --mp4vidtrack 5df914ce77..., Last passed: Test 5581
ccextractor --wtvconvertfix acf871cbfd..., Last passed: Test 5581
ccextractor --wtvmpeg2 10f0f77cf4..., Last passed: Test 5581
ccextractor --hauppauge d6df1b227a..., Last passed: Test 5581
ccextractor --xmltv --out=null 96efd279cf..., Last passed: Test 5581
ccextractor --codec dvbsub --out=spupng 85271be4d2..., Last passed: Test 5581
ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5581
ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5581
ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5581
ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5581
ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5581
ccextractor --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 5581
ccextractor --endcreditsforatleast 3 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 5581
ccextractor --endcreditsforatmost 2 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 5581
ccextractor --tpage 801 4e56e88ba4..., Last passed: Test 5581
ccextractor --tverbose 4e56e88ba4..., Last passed: Test 5581
ccextractor --teletext 4e56e88ba4..., Last passed: Test 5581
ccextractor --out=txt --ucla c83f765c66..., Last passed: Test 5581
ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 4e56e88ba4..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 006fdc391a..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 b37ce60eb9..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 297a44921a..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 efbe129086..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 eae0077731..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 8c1615c1a8..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 c6407fb294..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --tpage 299 44c45593fb..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --tpage 299 b8c55aa2e9..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 b236a0590b..., Last passed: Test 5581
ccextractor --out=srt --latin1 f23a544ba8..., Last passed: Test 5581
ccextractor --out=srt --latin1 97cc394d87..., Last passed: Test 5581
ccextractor --out=srt --latin1 10f0f77cf4..., Last passed: Test 5581
ccextractor --out=srt --latin1 df3b4d62d3..., Last passed: Test 5581
ccextractor --out=srt --latin1 d7e7dbdf68..., Last passed: Test 5581
ccextractor --out=srt --latin1 76734ac4a7..., Last passed: Test 5581
ccextractor --out=srt --latin1 c791382c94..., Last passed: Test 5581
ccextractor --out=srt --latin1 f673b2f916..., Last passed: Test 5581
ccextractor --out=srt --latin1 da75bdee47..., Last passed: Test 5581
ccextractor --out=srt --latin1 bd6f33a669..., Last passed: Test 5581
ccextractor --out=srt --latin1 0e5e6b26be..., Last passed: Test 5581
ccextractor --out=srt --latin1 a226cc302d..., Last passed: Test 5581
ccextractor --out=srt --latin1 ae6327683e..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 725a49f871..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla d037c7509e..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --ucla d037c7509e..., Last passed: Test 5581
ccextractor --autoprogram --out=smptett --latin1 --ucla e274a73653..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla e274a73653..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla 85058ad37e..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b22260d065..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --ucla b22260d065..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --xds --ucla c813e713a0..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --ucla c813e713a0..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 27fab4dbb6..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --ucla 27fab4dbb6..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds bbd5bb52fc..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --ucla bbd5bb52fc..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b992e0cccb..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds d0291cdcf6..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7d2730d38e..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --ucla 7d2730d38e..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds c8dc039a88..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --ucla c8dc039a88..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 53339f3455..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --ucla 53339f3455..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 83b03036a2..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --ucla 83b03036a2..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7d3f25c32c..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --ucla 7d3f25c32c..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds f41d4c29a1..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --ucla f41d4c29a1..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 88cd42b89a..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --ucla 88cd42b89a..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --output-field 2 --ucla 88cd42b89a..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7f41299cc7..., Last passed: Test 5581
ccextractor --autoprogram --out=srt --latin1 --ucla 7f41299cc7..., Last passed: Test 5581
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 0069dffd21..., Last passed: Test 5581

Check the result page for more info.

cfsmp3

Thank you for working on migrating the ISDB decoder to Rust! The overall structure looks good and the build succeeds.

However, I found a critical memory safety bug that needs to be fixed:

Use-after-free in reserve_buf() (functions_isdb.rs:59-80):

let mut new_buf = Vec::with_capacity(blen);
new_buf.extend_from_slice(unsafe { std::slice::from_raw_parts(text.buf, text.used) });

text.buf = new_buf.as_mut_ptr();  // Store pointer to Vec's buffer
text.len = blen;
// BUG: new_buf is dropped here, freeing the memory!
// text.buf now points to freed memory - use-after-free!

The new_buf Vec goes out of scope and is deallocated, but text.buf still points to the freed memory. You correctly used std::mem::forget(buf) in allocate_text_node() to prevent this - the same pattern is needed here:

text.buf = new_buf.as_mut_ptr();
text.len = blen;
std::mem::forget(new_buf);  // Add this line to prevent deallocation!

Additionally, the old buffer (text.buf) should be freed before being replaced to avoid a memory leak. Something like:

// Free old buffer if it exists
if !text.buf.is_null() && text.len > 0 {
    unsafe { drop(Vec::from_raw_parts(text.buf, text.used, text.len)); }
}
// Then allocate new buffer...

This bug likely explains why the CI - linux sample platform tests are timing out - use-after-free can cause infinite loops, crashes, or memory corruption.

Other notes:

PR has merge conflicts that need to be resolved
Remove "WIP" from title when ready for final review
Consider adding unit tests for the Rust implementation to catch issues like this

Once the memory bug is fixed and rebased, this should be ready for more detailed functional testing.

vatsalkeshav · 2025-12-16T08:38:20Z

Sure

I'll push some local changes after working on #1679
which will address these issues.

cfsmp3 · 2026-02-01T01:55:07Z

Closed due to inactivity, feel free to submit a new one (make sure it's based off master) when you are ready to resume work.

vatsalkeshav · 2026-02-13T20:04:43Z

covered in #2109

vatsalkeshav force-pushed the isdb_migration branch from 1a64f79 to dd06fe2 Compare March 21, 2025 08:19

vatsalkeshav changed the title ~~[FEAT] added isdbs module in lib_ccxr~~ [WIP] added isdbs module in lib_ccxr Mar 21, 2025

vatsalkeshav marked this pull request as draft March 23, 2025 03:43

vatsalkeshav closed this Mar 23, 2025

vatsalkeshav reopened this Mar 23, 2025

vatsalkeshav force-pushed the isdb_migration branch from 0165690 to 2fa5da9 Compare March 23, 2025 06:51

vatsalkeshav marked this pull request as ready for review March 23, 2025 07:04

vatsalkeshav marked this pull request as draft March 23, 2025 13:09

vatsalkeshav marked this pull request as ready for review March 23, 2025 13:34

vatsalkeshav marked this pull request as draft March 23, 2025 13:36

vatsalkeshav force-pushed the isdb_migration branch from b3e38d4 to 6a4319d Compare March 23, 2025 13:36

vatsalkeshav changed the title ~~[WIP] added isdbs module in lib_ccxr~~ [feat] added isdbs module in lib_ccxr Mar 23, 2025

vatsalkeshav marked this pull request as ready for review March 23, 2025 13:59

added isdbs module in lib_ccxr

7d3f3d7

vatsalkeshav force-pushed the isdb_migration branch from 6a4319d to 2f6f178 Compare March 28, 2025 17:52

vatsalkeshav changed the title ~~[feat] added isdbs module in lib_ccxr~~ [FEAT] Add decoder_isdb module in lib_ccxr Mar 28, 2025

vatsalkeshav changed the title ~~[FEAT] Add decoder_isdb module in lib_ccxr~~ [FEAT] Add module decoder_isdb module in lib_ccxr Mar 28, 2025

some serious code refactoring

ccdfeee

vatsalkeshav force-pushed the isdb_migration branch from 5bae956 to ccdfeee Compare March 29, 2025 02:28

vats004 added 2 commits March 29, 2025 08:02

update lib_ccxr/cargo.lock

60d152a

fixed some typos

40c64d9

prateekmedia added the Rust label Mar 29, 2025

vatsalkeshav changed the title ~~[FEAT] Add module decoder_isdb module in lib_ccxr~~ [FEAT] Add module decoder_isdb in lib_ccxr Apr 12, 2025

vatsalkeshav changed the title ~~[FEAT] Add module decoder_isdb in lib_ccxr~~ [FEAT] WIP module decoder_isdb in lib_ccxr Apr 21, 2025

cfsmp3 requested changes Dec 16, 2025

View reviewed changes

cfsmp3 mentioned this pull request Dec 16, 2025

[FEAT] Add module decoder_xds to lib_ccxr #1679

Closed

11 tasks

cfsmp3 closed this Feb 1, 2026

vatsalkeshav deleted the isdb_migration branch February 12, 2026 10:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEAT] WIP module `decoder_isdb` in lib_ccxr#1676

[FEAT] WIP module `decoder_isdb` in lib_ccxr#1676
vatsalkeshav wants to merge 4 commits intoCCExtractor:masterfrom
vatsalkeshav:isdb_migration

vatsalkeshav commented Mar 16, 2025 •

edited

Loading

Uh oh!

ccextractor-bot commented Mar 16, 2025

Uh oh!

ccextractor-bot commented Mar 29, 2025

Uh oh!

cfsmp3 left a comment

Uh oh!

vatsalkeshav commented Dec 16, 2025

Uh oh!

cfsmp3 commented Feb 1, 2026

Uh oh!

vatsalkeshav commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vatsalkeshav commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ccextractor-bot commented Mar 16, 2025

Uh oh!

ccextractor-bot commented Mar 29, 2025

Uh oh!

cfsmp3 left a comment

Choose a reason for hiding this comment

Uh oh!

vatsalkeshav commented Dec 16, 2025

Uh oh!

cfsmp3 commented Feb 1, 2026

Uh oh!

vatsalkeshav commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vatsalkeshav commented Mar 16, 2025 •

edited

Loading