Skip to content

Conversation

@fcollman
Copy link
Collaborator

@fcollman fcollman commented Jan 22, 2026

Note

Improves resilience of periodic database cleanup.

  • Updates Celery task workflow:remove_expired_databases to bind=True, acks_late=True, autoretry_for=(Exception,), max_retries=3 for automatic retries and safer failure handling

Written by Cursor Bugbot for commit 42eb697. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

bind=True,
acks_late=True,
autoretry_for=(Exception,),
max_retries=3)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing self parameter for bound Celery task

High Severity

The bind=True option was added to the Celery task decorator, but the function signature is missing the required self parameter as the first argument. When Celery invokes this task, it will pass the task instance as the first positional argument, which will be incorrectly assigned to delete_threshold. This causes delete_threshold to receive a task object instead of an integer, leading to a TypeError when comparing len(databases) > delete_threshold at runtime. The task will fail on every invocation and retry 3 times with the same error.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants