Skip to content

Conversation

@SeanBryan51
Copy link
Collaborator

This is work around for initialising pixi environments from benchcab-dev.yaml. Pixi has problems handling the -r input when setting up the environment via pixi init --import $(realpath $HOME/benchcab)/.conda/benchcab-dev.yaml:

Error:   × Can't parse '-r mkdocs-requirements.txt' as pypi dependency
  ╰─▶ Expected package name starting with an alphanumeric character, found `-`
      -r mkdocs-requirements.txt
      ^

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.60%. Comparing base (8e0d58f) to head (7415287).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   68.28%   69.60%   +1.32%     
==========================================
  Files          21       21              
  Lines        1157     1214      +57     
==========================================
+ Hits          790      845      +55     
- Misses        367      369       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SeanBryan51 SeanBryan51 requested review from a team and ccarouge and removed request for a team October 22, 2025 03:59
Copy link
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain here. That's the quick solution but it's when we work on developments that we need a local install of mkdocs. It's a lot faster to deal with formatting etc. if we build the docs locally than pushing to GitHub to build the preview.

I know that copying the requirements in 2 places (benchcab-dev.yaml and mkdocs-requirements.txt) is not great but removing installing mkdocs in the dev environment is annoying.

@SeanBryan51
Copy link
Collaborator Author

Just confirmed that copying the contents of mkdocs-requirements.txt into benchcab-dev.yaml (under pip:) works fine with pixi. I don't mind the extra duplication either.

I will update.

@SeanBryan51 SeanBryan51 changed the title .conda/benchcab-dev.yaml: remove mkdocs dependencies .conda/benchcab-dev.yaml: remove inclusion of mkdocs-requirements.txt Oct 22, 2025
This is work around for initialising pixi environments from
benchcab-dev.yaml. Pixi has problems handling the -r input when
setting up the environment via pixi init --import:

Error:   × Can't parse '-r mkdocs-requirements.txt' as pypi dependency
  ╰─▶ Expected package name starting with an alphanumeric character, found `-`
      -r mkdocs-requirements.txt
      ^
@SeanBryan51 SeanBryan51 force-pushed the remove-mkdocs-dependencies-from-dev-env branch from 5fa03c9 to 7415287 Compare October 22, 2025 04:58
@SeanBryan51 SeanBryan51 requested a review from ccarouge October 22, 2025 04:58
Copy link
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SeanBryan51 SeanBryan51 merged commit bb8cda6 into main Oct 26, 2025
3 checks passed
@SeanBryan51 SeanBryan51 deleted the remove-mkdocs-dependencies-from-dev-env branch October 26, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants