Configure a FileDataIniParser to handle duplicate keys #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ini files, for cases like the Tank.ini where it has a duplicate key DEAD in its sound effects
TomWerner
approved these changes
Jan 19, 2026
| if (fileIniDataParser != null) return fileIniDataParser; | ||
|
|
||
| FileIniDataParser parser = new FileIniDataParser(); | ||
| parser.Parser.Configuration.AllowDuplicateKeys = true; |
Contributor
There was a problem hiding this comment.
Could you leave a comment explaining why we would set these?
ConvertCiv3Media/Civ3UnitSprite.cs
Outdated
| public Civ3UnitSprite(Civ3UnitSprite civ3UnitSprite) { | ||
| } | ||
|
|
||
| /* |
Contributor
There was a problem hiding this comment.
I'd just delete any of this that isn't used. We can always bring it back from version control if needed.
Contributor
Author
There was a problem hiding this comment.
The whole file is unused, should I just delete it as a whole?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure a FileDataIniParser to allow and override duplicate keys in .ini files, for cases like the Tank.ini that has a duplicate key DEAD in its sound effects.
Closes #856
I also commented out part of Civ3UnitSprite class that used a FileDataIniParser as the class itself seems to no longer be in use. Potentially we can completely remove it.