Use tomllib rather than toml #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Judging by mwouts/jupytext#1195 (comment)
which notes the fact tomli is in core Python 3.11+, seems like a
no-brainer, will merge this and look into the rest of the PRs you sent later
…On Thu, Mar 6, 2025, 12:39 James Le Cuirot ***@***.***> wrote:
The toml library has been unmaintained for years and is no longer packaged
by some distributions.
------------------------------
You can view, comment on, or merge this pull request online at:
#71
Commit Summary
- 80ecb03
<80ecb03>
Use tomli rather than toml
File Changes
(3 files <https://github.com/C0rn3j/sc-controller/pull/71/files>)
- *M* .github/workflows/scc-linux.yml
<https://github.com/C0rn3j/sc-controller/pull/71/files#diff-343ca8e151e0a13c117f3654975fab27974f4a132caf3715479ad810f85bde18>
(2)
- *M* Dockerfile
<https://github.com/C0rn3j/sc-controller/pull/71/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557>
(2)
- *M* tests/test_setup.py
<https://github.com/C0rn3j/sc-controller/pull/71/files#diff-147f0be1d0fea767cb6ff2ba9f23c0e9a8dcb91474b1b2f3ec529072d5f54f02>
(5)
Patch Links:
- https://github.com/C0rn3j/sc-controller/pull/71.patch
- https://github.com/C0rn3j/sc-controller/pull/71.diff
—
Reply to this email directly, view it on GitHub
<#71>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMQXEQSJMTAPKMJQAHWFPD2TAXWPAVCNFSM6AAAAABYOO3OJOVHI2DSMVQWIX3LMV43ASLTON2WKOZSHEYDAMJWGQ3DMMI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
C0rn3j
reviewed
Mar 9, 2025
C0rn3j
reviewed
Mar 9, 2025
The toml library has been unmaintained for years and is no longer packaged by some distributions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toml library has been unmaintained for years and is no longer packaged by some distributions.