Skip to content

Conversation

@KenVanHoeylandt
Copy link
Member

@KenVanHoeylandt KenVanHoeylandt commented Jan 7, 2026

Fix to support building for multiple architectures

@coderabbitai
Copy link

coderabbitai bot commented Jan 7, 2026

📝 Walkthrough

Walkthrough

The GitHub Actions build step was changed to reset the IDF_TARGET environment variable by prepending export IDF_TARGET= && before invoking python3 tools/tactility.py build. Comments explaining the purpose of the export were added. No other changes to the build logic or control flow were introduced.

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author, making it impossible to evaluate whether the intent and rationale are clearly communicated. Add a description explaining the CI issue that was fixed, why the environment reset is necessary, and how it resolves the problem.
Title check ❓ Inconclusive The title 'CI fix' is vague and generic, using non-descriptive language that doesn't convey specific information about what CI issue was fixed. Replace with a more specific title like 'Reset IDF_TARGET environment variable in build step' to clearly describe the fix being applied.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/actions/build-app/action.yml:
- Line 19: The workflow sets IDF_TARGET to an empty value in the command string
which breaks ESP-IDF CMake; instead remove the "export IDF_TARGET=" workaround
and configure the espressif/esp-idf-ci-action invocation to use its built-in
target input (e.g., set target: esp32) and keep the command as "python
tactility.py build" so the action's target input controls the IDF target rather
than a blank IDF_TARGET env var.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6c27b6 and 499c652.

📒 Files selected for processing (1)
  • .github/actions/build-app/action.yml

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/actions/build-app/action.yml:
- Around line 19-21: The current command sets IDF_TARGET to an empty string
which breaks ESP-IDF CMake; remove the export workaround in the action.yml
command (the 'command' key) and instead pass the intended ESP target via the
espressif/esp-idf-ci-action@v1 `target` input parameter (defaults to "esp32");
update the action invocation to remove "export IDF_TARGET=" from the command and
add or rely on the `target` input on the espressif action so the build uses the
proper target initialization.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 499c652 and 43e72cb.

📒 Files selected for processing (1)
  • .github/actions/build-app/action.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Build (Calculator)
  • GitHub Check: Build (HelloWorld)
  • GitHub Check: Build (TwoEleven)
  • GitHub Check: Build (GPIO)
  • GitHub Check: Build (Diceware)
  • GitHub Check: Build (GraphicsDemo)
  • GitHub Check: Build (SerialConsole)

@KenVanHoeylandt KenVanHoeylandt merged commit eeef409 into main Jan 7, 2026
9 checks passed
@KenVanHoeylandt KenVanHoeylandt deleted the develop branch January 7, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants