-
-
Notifications
You must be signed in to change notification settings - Fork 4
CI fix #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI fix #20
Conversation
📝 WalkthroughWalkthroughThe GitHub Actions build step was changed to reset the IDF_TARGET environment variable by prepending 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/actions/build-app/action.yml:
- Line 19: The workflow sets IDF_TARGET to an empty value in the command string
which breaks ESP-IDF CMake; instead remove the "export IDF_TARGET=" workaround
and configure the espressif/esp-idf-ci-action invocation to use its built-in
target input (e.g., set target: esp32) and keep the command as "python
tactility.py build" so the action's target input controls the IDF target rather
than a blank IDF_TARGET env var.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/actions/build-app/action.yml:
- Around line 19-21: The current command sets IDF_TARGET to an empty string
which breaks ESP-IDF CMake; remove the export workaround in the action.yml
command (the 'command' key) and instead pass the intended ESP target via the
espressif/esp-idf-ci-action@v1 `target` input parameter (defaults to "esp32");
update the action invocation to remove "export IDF_TARGET=" from the command and
add or rely on the `target` input on the espressif action so the build uses the
proper target initialization.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/actions/build-app/action.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Build (Calculator)
- GitHub Check: Build (HelloWorld)
- GitHub Check: Build (TwoEleven)
- GitHub Check: Build (GPIO)
- GitHub Check: Build (Diceware)
- GitHub Check: Build (GraphicsDemo)
- GitHub Check: Build (SerialConsole)
Fix to support building for multiple architectures