Skip to content

Only install npm through APT when node version is under 20 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poespas merged 1 commit into from
Mar 24, 2025
Merged

Only install npm through APT when node version is under 20 #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ci/build/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ RUN apt-get update && \
make \
libtool \
nodejs \
npm \
gnupg \
zip \
bc \
Expand Down Expand Up @@ -82,6 +81,13 @@ RUN apt-get update && \
php${PHP_VERSION}-zip \
&& rm -rf /var/lib/apt/lists/*

# Only install npm if node version is less than 20, otherwise it's already installed
RUN if [ "${NODE_VERSION}" -lt 20 ]; then \
apt-get update \
&& apt-get install -y --no-install-recommends npm \
&& rm -rf /var/lib/apt/lists/*; \
fi

COPY ./.git /hypernode/.git
COPY ./bin /hypernode/bin
COPY ./ci /hypernode/ci
Expand Down
Loading