Rewrite Components Using React #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@andersevenrud Do you have time to take a look at these changes? 😁 |
|
I totally forgot about this 😊 I'll try to look at this week, but chances are that I don't have time before the weekend. A thought: Maybe it would be better to have this in a completely clean repo instead of basing it off the official |
Author
|
I thought it'd make the review easier as you will only need to check the changes. And, we can remove the history after the review is done. |
|
I did not get a chance to look at this because my internet disappeared for an entire week 😅 But I've done so now, and it looks really good. I'm going to test it out for a bit as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to rewrite @osjs/gui using React to be used as a separate package for React users of osjs.
Related issue: #36