Implement updates tracking OWID grapher#6
Open
xrendan wants to merge 741 commits intoBuildCanada:masterfrom
Open
Implement updates tracking OWID grapher#6xrendan wants to merge 741 commits intoBuildCanada:masterfrom
xrendan wants to merge 741 commits intoBuildCanada:masterfrom
Conversation
improve Resolve focus placeholders when looking up reference queries The resolved/unresolved query-string handling was incorrect when a focus parameter was present: reference lookups used the unresolved query string instead of the resolved one. This caused mismatches when comparing graphs that used focus placeholders. To fix this, added a helper to resolve focus placeholders (resolveQueryStrForLookup) that creates a minimal grapher state to compute the resolved query string, and updated verification to use the resolved query string. Also corrected diff line counting to separately compute added/deleted lines and use the maximum as the changed-lines count. Use unresolved query string for SVG records When resolving focus placeholders required loading grapher data, generating a minimal grapher was complex and unnecessary for lookup purposes. Instead, keep and use the original/unresolved query string for SVG record keys and export lookups. This simplifies rendering and lookup logic by removing resolveQueryStrForLookup and related resolution steps, and ensures chart keys are created from the provided query string directly. Include query string when opening SVG in report When opening an SVG from the HTML report, the query string on the record was not being included in the generated links or displayed title, causing opened charts to miss context provided by URL parameters. This change reads queryStr from the svgRecord and appends it to viewId for full links, uses the combined value for the copy-to-clipboard button, and shows the query string in the section title so the correct URL and label are preserved when viewing or copying. Include resolvedQueryStr in svg records and UI Add resolvedQueryStr to the SvgRecord type and propagate it through utils, parsing, and view generation so the compare view and HTML report can use the resolved query string (with actual entity names) where available. This change makes the displayed and copyable URLs use resolvedQueryStr if present, falling back to the original queryStr, improving clarity when placeholders (e.g. <firstSeries>) have been replaced.
Fixing: Set is not a function or its return value is not iterable
* 🔨🤖 Remove unused ETL API metadata editing from variable edit page Remove the functionality that allowed editing indicator metadata from the Admin UI via the ETL API. This was introduced in #3106 but never actively used in practice — metadata is edited directly in the ETL repo's YAML files. - Remove save(), etlApiIsRunning(), getDifference(), VariableEditable class - Remove ETL_API_URL from client settings - Convert all metadata fields to read-only display - Remove BindStringArray and BindDropdown from Forms.tsx (now unused) * wip * 🤖 style: format code * ✨🤖 Address review: use ReadOnlyField consistently, remove help text - Convert remaining TextAreaFields (Description key, Entity annotations) to ReadOnlyField for consistency - Remove editing-oriented help text from Entity annotations --------- Co-authored-by: Marigold <1550888+Marigold@users.noreply.github.com>
add more polyfills for modern features
- Add .gitignore entries for Auto Claude files (.auto-claude/, .auto-claude-security.json, .auto-claude-status, .claude_settings.json) - Add --disable-nested-config to oxlint commands to prevent picking up oxlintrc files from worktree subdirectories Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
## Summary - Add `.gitignore` entries for Auto Claude files (`.auto-claude/`, `.auto-claude-security.json`, `.auto-claude-status`, `.claude_settings.json`) - Add `--disable-nested-config` to oxlint commands to prevent picking up `oxlintrc` files from worktree subdirectories ## Test plan - [x] `yarn testLintChanged` still works correctly - [x] Auto Claude files are ignored by git
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Links to issues, Figma, Slack, and a technical introduction to the work.
Screenshots / Videos / Diagrams
Add if relevant, i.e. might not be necessary when there are no UI changes.
Testing guidance
Step-by-step instructions on how to test this change
Reminder to annotate the PR diff with design notes, alternatives you considered, and any other helpful context.
Checklist
(delete all that do not apply)
Before merging
If DB migrations exists:
After merging